linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	petr.pavlu@suse.com, samitolvanen@google.com,
	da.gomez@samsung.com, masahiroy@kernel.org, deller@gmx.de,
	linux-arch@vger.kernel.org, live-patching@vger.kernel.org,
	kris.van.hees@oracle.com
Subject: Re: [PATCH v3] selftests: add new kallsyms selftests
Date: Thu, 24 Oct 2024 13:21:32 -0700	[thread overview]
Message-ID: <ZxqsTO0BAQLPJDJL@bombadil.infradead.org> (raw)
In-Reply-To: <368aa911-7a88-4a00-8830-4a183fd6f352@quicinc.com>

On Wed, Oct 23, 2024 at 10:28:49AM -0700, Jeff Johnson wrote:
> On 10/21/24 12:33, Luis Chamberlain wrote:
> ...
> > +gen_template_module_exit()
> > +{
> > +	cat <<____END_MODULE
> > +static int __init auto_test_module_init(void)
> > +{
> > +	return auto_runtime_test();
> > +}
> > +module_init(auto_test_module_init);
> > +
> > +static void __exit auto_test_module_exit(void)
> > +{
> > +}
> > +module_exit(auto_test_module_exit);
> > +
> > +MODULE_AUTHOR("Luis Chamberlain <mcgrof@kernel.org>");
> > +MODULE_LICENSE("GPL");
> > +____END_MODULE
> > +}
> 
> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
> description is missing"), a module without a MODULE_DESCRIPTION() will
> result in a warning when built with make W=1. Is that a concern here?
> Should we add a MODULE_DESCRIPTION()?

News to me, I'll send a follup patch with just that alone as I already
merged this onto modules-next.

  Luis

  reply	other threads:[~2024-10-24 20:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 19:33 [PATCH v3] selftests: add new kallsyms selftests Luis Chamberlain
2024-10-23 17:28 ` Jeff Johnson
2024-10-24 20:21   ` Luis Chamberlain [this message]
2024-10-29 16:24 ` Sami Tolvanen
2024-11-06  0:21   ` Luis Chamberlain
2024-11-28 14:10 ` Geert Uytterhoeven
2024-11-28 19:34   ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxqsTO0BAQLPJDJL@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=da.gomez@samsung.com \
    --cc=deller@gmx.de \
    --cc=kris.van.hees@oracle.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=samitolvanen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).