Linux Modules
 help / color / mirror / Atom feed
From: Petr Pavlu <petr.pavlu@suse.com>
To: "Thiébaud Weksteen" <tweek@google.com>
Cc: Aaron Tomlin <atomlin@atomlin.com>,
	Markus Elfring <Markus.Elfring@web.de>,
	linux-modules@vger.kernel.org, Daniel Gomez <da.gomez@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Siddharth Nayyar <sidnayyar@google.com>
Subject: Re: [PATCH] module: validate string table section types
Date: Tue, 14 Jul 2026 13:33:53 +0200	[thread overview]
Message-ID: <a9029c20-c6ac-4d2c-9f41-b49a83ff5c22@suse.com> (raw)
In-Reply-To: <CA+zpnLexK1qbCxpwQdP76B+F0JqCFJL3rEWnp8xShbLbepvuXA@mail.gmail.com>

On 7/14/26 1:37 AM, Thiébaud Weksteen wrote:
> On Mon, Jul 13, 2026 at 10:14 PM Aaron Tomlin <atomlin@atomlin.com> wrote:
>>
>> On Fri, Jul 10, 2026 at 10:23:00AM +0200, Markus Elfring wrote:
>>> …
>>>> Validate that both string section headers are of type SHT_STRTAB before
>>>> caching them.
>>>
>>> How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
> 
> Thanks for the suggestion. I can't seem to find any relevant commit
> for Fixes. There are
> ec2a29593c83e ("module: harden ELF info handling") and potentially
> 3c5700aeabd87 ("module: Factor out elf_validity_cache_secstrings")
> Both of these commits already intended to harden the parsing. I don't
> think there is any regression here.

I agree.

> As for Cc:, I can't think of anyone who should be explicitly added. If
> you have any suggestions, please chime in.

I'll add 'Cc: stable@vger.kernel.org' when queuing the patch.

-- 
Thanks,
Petr

  reply	other threads:[~2026-07-14 11:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08  1:21 [PATCH] module: validate string table section types Thiébaud Weksteen
2026-07-08  1:33 ` sashiko-bot
2026-07-08 15:40 ` Petr Pavlu
2026-07-09  1:56   ` Thiébaud Weksteen
2026-07-09  9:23     ` Petr Pavlu
2026-07-10  8:23 ` Markus Elfring
2026-07-13 12:14   ` Aaron Tomlin
2026-07-13 23:37     ` Thiébaud Weksteen
2026-07-14 11:33       ` Petr Pavlu [this message]
2026-07-10 15:37 ` Aaron Tomlin
2026-08-06 12:17 ` Petr Pavlu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9029c20-c6ac-4d2c-9f41-b49a83ff5c22@suse.com \
    --to=petr.pavlu@suse.com \
    --cc=Markus.Elfring@web.de \
    --cc=atomlin@atomlin.com \
    --cc=da.gomez@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=samitolvanen@google.com \
    --cc=sidnayyar@google.com \
    --cc=tweek@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox