From: Luis Chamberlain <mcgrof@kernel.org>
To: "Herton R. Krzesinski" <herton@redhat.com>
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, petr.pavlu@suse.com,
samitolvanen@google.com, da.gomez@samsung.com, nathan@kernel.org
Subject: Re: [PATCH v2] lib/test_kmod: do not hardcode/depend on any filesystem
Date: Fri, 18 Apr 2025 10:54:18 -0700 [thread overview]
Message-ID: <aAKRygQdkdlyZ_ai@bombadil.infradead.org> (raw)
In-Reply-To: <20250418165047.702487-1-herton@redhat.com>
On Fri, Apr 18, 2025 at 01:50:47PM -0300, Herton R. Krzesinski wrote:
> Right now test_kmod has hardcoded dependencies on btrfs/xfs. That
> is not optimal since you end up needing to select/build them, but it
> is not really required since other fs could be selected for the testing.
> Also, we can't change the default/driver module used for testing on
> initialization.
>
> Thus make it more generic: introduce two module parameters (start_driver
> and start_test_fs), which allow to select which modules/fs to use for
> the testing on test_kmod initialization. Then it's up to the user to
> select which modules/fs to use for testing based on his config. However,
> keep test_module as required default.
>
> This way, config/modules becomes selectable as when the testing is done
> from selftests (userspace).
>
> While at it, also change trigger_config_run_type, since at module
> initialization we already set the defaults at __kmod_config_init and
> should not need to do it again in test_kmod_init(), thus we can
> avoid to again set test_driver/test_fs.
>
> v2: also update tools/testing/selftests/kmod/config with the removed
> dependencies.
>
> Signed-off-by: Herton R. Krzesinski <herton@redhat.com>
Reviewed-by: Luis Chambelrain <mcgrof@kernel.org>
Luis
prev parent reply other threads:[~2025-04-18 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 16:50 [PATCH v2] lib/test_kmod: do not hardcode/depend on any filesystem Herton R. Krzesinski
2025-04-18 17:54 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAKRygQdkdlyZ_ai@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=da.gomez@samsung.com \
--cc=herton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).