From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02492221F13; Tue, 16 Sep 2025 09:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758015457; cv=none; b=AjMaeMPRF129uGM95w1pWviiz3OJt7+AvdO2NCRjiJyXpDnH/QIHjHm1BIcwaDicptHJDYu6ZwxZp276iA9VUIHNEdaOKAQYZh71wo7f8hb3nNMCKtSO2zvIVvJKyAbpivtY6Ndpd0mAYAwyJx9VFFEBkho5HKj0/LeY1GzvSTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758015457; c=relaxed/simple; bh=zFqtE/qNhnj5QoIqzFKnaCQYnyy/uOAyvfVMAV8OuuI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XtU/ZhDTuiEjO1cKEZOxQ5KkOQhU5fIM1Sb2n21f8xnVzC3a1YXKg9jbRluaxVKqQNAe30LXFdYgJlUo0J8YZhNcfIL6nUFP+KWjExpB2wVxEZTu6j1hA+aOgU7pC2VBovWlgiCBLIXEX8bOMUjo2Qd1xPrG7D8HLcMUKssoZ1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kfpnD8Le; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kfpnD8Le" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E1DEC4CEEB; Tue, 16 Sep 2025 09:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758015456; bh=zFqtE/qNhnj5QoIqzFKnaCQYnyy/uOAyvfVMAV8OuuI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kfpnD8LewKPf4aF4rqDRFTB557nfWps9/hoxTv0uzVvACdoLyJ/DQLYYQH260i/Z2 wDIM3roPGXB727cxfQsIt5E2rSS6EMoQHNaQ53zB3J32+mSic9JBmqkRdfcuv+QbhB TicaxGCXweX6KZBHxCWVU/TR66KbFF9Vb8LE8qV1l7G75VdXkjdTjUwLEawPi43AZB AU5EhpxJ5zKNDDYr3/V1WY9ITnBiIx5xnnA4d9rV2N7T4FlQuvGh/zLrpE9qJ3qdCj G5ftV+/5fA75+epIiJFFJDxeXlwLLHqdhHTVIpRIIONQu3s1gknP52SWR1686a2ETA 3IGexham0iK+g== Date: Tue, 16 Sep 2025 11:36:54 +0200 From: Nicolas Schier To: Alexey Gladkov Cc: Nathan Chancellor , Petr Pavlu , Luis Chamberlain , Sami Tolvanen , Daniel Gomez , linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, Masahiro Yamada Subject: Re: [PATCH v7 3/8] kbuild: keep .modinfo section in vmlinux.unstripped Message-ID: References: <4d53c72293d88b663257a0d723ebf3473a08b374.1755535876.git.legion@kernel.org> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 16, 2025 at 09:12:22AM +0200, Alexey Gladkov wrote: > On Mon, Sep 15, 2025 at 07:56:16AM +0200, Nicolas Schier wrote: > > On Mon, Aug 18, 2025 at 06:54:57PM +0200, Alexey Gladkov wrote: > > > From: Masahiro Yamada > > > > > > Keep the .modinfo section during linking, but strip it from the final > > > vmlinux. > > > > > > Adjust scripts/mksysmap to exclude modinfo symbols from kallsyms. > > > > > > This change will allow the next commit to extract the .modinfo section > > > from the vmlinux.unstripped intermediate. > > > > > > Signed-off-by: Masahiro Yamada > > > --- > > > include/asm-generic/vmlinux.lds.h | 2 +- > > > scripts/Makefile.vmlinux | 2 +- > > > scripts/mksysmap | 3 +++ > > > 3 files changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > > > index ae2d2359b79e9..cfa63860dfd4c 100644 > > > --- a/include/asm-generic/vmlinux.lds.h > > > +++ b/include/asm-generic/vmlinux.lds.h > > > @@ -831,6 +831,7 @@ defined(CONFIG_AUTOFDO_CLANG) || defined(CONFIG_PROPELLER_CLANG) > > > > > > /* Required sections not related to debugging. */ > > > #define ELF_DETAILS \ > > > + .modinfo : { *(.modinfo) } \ > > > .comment 0 : { *(.comment) } \ > > > .symtab 0 : { *(.symtab) } \ > > > .strtab 0 : { *(.strtab) } \ > > > @@ -1044,7 +1045,6 @@ defined(CONFIG_AUTOFDO_CLANG) || defined(CONFIG_PROPELLER_CLANG) > > > *(.discard.*) \ > > > *(.export_symbol) \ > > > *(.no_trim_symbol) \ > > > - *(.modinfo) \ > > > /* ld.bfd warns about .gnu.version* even when not emitted */ \ > > > *(.gnu.version*) \ > > > > > > diff --git a/scripts/Makefile.vmlinux b/scripts/Makefile.vmlinux > > > index 4f2d4c3fb7372..e2ceeb9e168d4 100644 > > > --- a/scripts/Makefile.vmlinux > > > +++ b/scripts/Makefile.vmlinux > > > @@ -86,7 +86,7 @@ endif > > > # vmlinux > > > # --------------------------------------------------------------------------- > > > > > > -remove-section-y := > > > +remove-section-y := .modinfo > > > remove-section-$(CONFIG_ARCH_VMLINUX_NEEDS_RELOCS) += '.rel*' > > > > > > quiet_cmd_strip_relocs = OBJCOPY $@ > > > diff --git a/scripts/mksysmap b/scripts/mksysmap > > > index 3accbdb269ac7..a607a0059d119 100755 > > > --- a/scripts/mksysmap > > > +++ b/scripts/mksysmap > > > @@ -79,6 +79,9 @@ > > > / _SDA_BASE_$/d > > > / _SDA2_BASE_$/d > > > > > > +# MODULE_INFO() > > > +/ __UNIQUE_ID_modinfo[0-9]*$/d > > > + > > > # --------------------------------------------------------------------------- > > > # Ignored patterns > > > # (symbols that contain the pattern are ignored) > > > -- > > > 2.50.1 > > > > > > > Hi Alexey, > > > > with this patch applied, I still get a warning from objcpy as Masahiro > > and Stephen wrote [1,2] > > > > SORTTAB vmlinux.unstripped > > + sorttable vmlinux.unstripped > > + nm -S vmlinux.unstripped > > + ./scripts/sorttable -s .tmp_vmlinux.nm-sort vmlinux.unstripped > > + is_enabled CONFIG_KALLSYMS > > + grep -q ^CONFIG_KALLSYMS=y include/config/auto.conf > > + cmp -s System.map .tmp_vmlinux2.syms > > + echo vmlinux.unstripped: ../scripts/link-vmlinux.sh > > # OBJCOPY vmlinux > > objcopy --remove-section=.modinfo vmlinux.unstripped vmlinux > > objcopy: vmlinux.unstripped: warning: empty loadable segment detected at vaddr=0xffff8000807a0000, is this intentional? > > > > (arm64, allnoconfig) > > > > Kind regards, > > Nicolas > > > > > > [1]: https://lore.kernel.org/linux-kbuild/CAK7LNAR-gD2H6Kk-rZjo0R3weTHCGTm0a=u2tRH1WWW6Sx6=RQ@mail.gmail.com/ > > [2]: https://lore.kernel.org/lkml/20250730164047.7c4a731a@canb.auug.org.au/ > > > > Hm. I missed that. I need to investigate how to fix this. Nothing comes > to mind right now. Same here. Only thing I could find until now is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/scripts/link-vmlinux.sh?id=90ceddcb495008ac8ba7a3dce297841efcd7d584 where '2>/dev/null' is appended exactly to prevent this very warning. But for me, it doesn't feel good doing that when stripping to vmlinux. -- Nicolas