From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f46.google.com (mail-yx1-f46.google.com [74.125.224.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 857FE17A2FC for ; Sun, 30 Nov 2025 17:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764525370; cv=none; b=eOYqxaC9YVj96VfRoiTHoQIDTfLuQvqjMfzbkRCvLz3IIllMt1NxRDvHv2tOekG7xKWdVPXxf5dDvbLrzxtXqOmJfazMsCWI7eKiM9vhpmhGPcHr8VpkrQ8zAiPK7UXEsItjRh3KzR675S4cfnfx/3UJo/zhVVDSiSNxjzM5WtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764525370; c=relaxed/simple; bh=27WbreY2RKmBEG/BW9KQXhwy/0tZWPSyiK6pn9laG6g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HZx46LJ2ShnVk2kdr6buAylMRXX7qar28wSZ0jesCDO+jSVW+fTwMgcE6Sj/jUCAL3KonsAAT+MsNHWLvM/pMEXI3e7xyRZRVgTuI6jO2/UvWMoL6oPvFt85ElZ4r/xQ7YVrpEORHv7fleZo5rQKTmrCZmOgeK+z5LulWgHUMiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jqNts4w2; arc=none smtp.client-ip=74.125.224.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jqNts4w2" Received: by mail-yx1-f46.google.com with SMTP id 956f58d0204a3-640d0895d7cso4284571d50.1 for ; Sun, 30 Nov 2025 09:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764525366; x=1765130166; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wUD/yBt9NZ9+A9XDWEgi0gEwekBnc6bPrryNuMfZMEw=; b=jqNts4w2unHzV47JmXIbCJ7rKQzQZ0wAWkLT1kyHY4rCVObgD9iR6kW31XWKz0rrBI mTzZAwVKaU3RE11n8WTkbgW4vPRVINIGeQUGqYhD9UQ9DhhO84aDdzpN5P6FYxXFbP6+ hOk9WmwzGz0zQ2Ac4sf4tqaREcyp8ei6ydBM44CyI4T0ZGHC5p1nRkZE2xF4oDN9YH50 duDK7rp4o+MWeB7H4X1demIvhShJaXGYPPiAglTXOxQmV61FdxFN445VYmAzTM7OpH+n b2/Sgl8EyfB0yQNQz9zZpKxF3A426ZHr8r90P7ZFcCUTUQas1RtJ4ocuGr6+onM3agHo t2kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764525366; x=1765130166; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wUD/yBt9NZ9+A9XDWEgi0gEwekBnc6bPrryNuMfZMEw=; b=qetvlStf/cbvG6FyKCqNjKzvJBybDBNnjON55wPCCups7IpkLFKTQenoTrvRh/om9o ySlhrOMJ6J79pvUNCXrj4vyF6jChzpTmHfIwbwr+6x9YIWM/QoIydQg1kV4aOAr7NelG cEE26EIDqblh+57MZNzWj/UzplkDAZnyOsUy6kisFxDekxw9ivUTJla/hzbSvR2W15lI t1P03el1wU9kP2uyaiow0S9Ogcv5f6YGBOAfUapfyTQc/gstkBBesN+7qD6TF4EG6Kza 6OXTY6gUi7n0cWP8s85VG1TfslC35gE+NN7d9Tlr7FeDeVvwBPSDSOBGX02r6nSfeyyh vC7w== X-Forwarded-Encrypted: i=1; AJvYcCX8nzpnPoSOq5ccAkteW1+r3ZHQOZdW6mjJnJyXle4KnyngY9LgpSWoG12gCEBA+AFzpAGg31sGwpJzdHgE@vger.kernel.org X-Gm-Message-State: AOJu0YwHj3wSOBCMpAC2Jq1q1rbA+dqyNl1KoYi/NG15LDrQbRkVRj57 oSsVIMOMA244Xr/KkDyHrf+Os67r9XDzn1JRe8LiAq3docXQZexK/jK8 X-Gm-Gg: ASbGnctxG3zKe6XdNVPGO8kKuHtOKjHBC8AiNrZSSADXlj1SHsgd8i92gFlBMquQjLf 5JP6y6XXeTrKKsSzvgdhk4H5brE6ltqgWaRXx30G+4CqrkfxotJovAK2cNDBCj6Rb+lgJmraQ93 iJf4jQk5N28mMlp/UZFyP182J+N4FE2ntm4uE7orxmakr+1WK38RwWL0s10/ihTD/1jrEYEI2Ly WB3sCOlMgQkMUh/0+hVTMFsypwEJmsMx6Yl1ZNRvRrD2N7AOzvTUpmGdGBaqxJhBe9bypULdtki 0/VuVzjUjlmK4k7GzaXfGIpYT3sUiB9BwqtBZEf5ZTHNKRbAeAlqL/0rdxju53HX8TGEzjQDY+B ZN/2JFTMtzhxyxXQAtCRBdUu5NstXFzKfmzlzNJeQ9AD/lHYKnON1TRxTtN2azyhZr/e32ZMtKu FwCKMh/No= X-Google-Smtp-Source: AGHT+IFazktIfCN3qlxWEck8ZBpdX6Q85L5F/mb8r4CtsaC7PGh9ijpwS9MHVlr3YNeQOBcTLxwxaw== X-Received: by 2002:a05:690e:1483:b0:640:d1cc:2be7 with SMTP id 956f58d0204a3-642f8e41c16mr30276137d50.30.1764525366495; Sun, 30 Nov 2025 09:56:06 -0800 (PST) Received: from localhost ([2601:346:0:79bd:b42b:4ad9:10af:cabc]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6433c4692a2sm3805357d50.17.2025.11.30.09.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 09:56:06 -0800 (PST) Date: Sun, 30 Nov 2025 12:56:05 -0500 From: Yury Norov To: Andy Shevchenko Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Randy Dunlap , Ingo Molnar , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Petr Pavlu , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] kernel.h: move VERIFY_OCTAL_PERMISSIONS() to sysfs.h Message-ID: References: <20251129195304.204082-1-yury.norov@gmail.com> <20251129195304.204082-3-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Nov 29, 2025 at 10:35:54PM +0200, Andy Shevchenko wrote: > On Sat, Nov 29, 2025 at 10:34:02PM +0200, Andy Shevchenko wrote: > > On Sat, Nov 29, 2025 at 10:24:55PM +0200, Andy Shevchenko wrote: > > > On Sat, Nov 29, 2025 at 02:53:01PM -0500, Yury Norov (NVIDIA) wrote: > > > > The macro is related to sysfs, but is defined in kernel.h. Move it to > > > > the proper header, and unload the generic kernel.h. > > > > > > Tough guy :-) > > > I hope it builds well in your case. > > > > > > FWIW, > > > https://lore.kernel.org/lkml/20220603172101.49950-1-andriy.shevchenko@linux.intel.com/ > > > https://lore.kernel.org/lkml/20240212115500.2078463-1-max.kellermann@ionos.com/ > > > https://lore.kernel.org/lkml/20240215093646.3265823-1-max.kellermann@ionos.com/ > > > > > > Assuming it builds in allmodconfig, allyesconfig on x86_32/64 and arm/64 > > > Reviewed-by: Andy Shevchenko > > > > Actually, one thing should be fixed, i.e. > > Documentation/filesystems/sysfs.rst:123:Note as stated in include/linux/kernel.h "OTHER_WRITABLE? ... > > And just in case, look into > https://lore.kernel.org/r/20251126214709.2322314-1-andriy.shevchenko@linux.intel.com Sure. Please find attached. >From 8b08bfd1d4b885bffb67c548d17d98760ca06e76 Mon Sep 17 00:00:00 2001 From: "Yury Norov (NVIDIA)" Date: Sun, 30 Nov 2025 12:50:11 -0500 Subject: [PATCH] sysfs: Align update documentation This series moves VERIFY_OCTAL_PERMISSIONS() from linux/kernel.h to linux/sysfs.h. Update documentation accordingly Suggested-by: Andy Shevchenko Signed-off-by: Yury Norov (NVIDIA) --- Documentation/filesystems/sysfs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/filesystems/sysfs.rst b/Documentation/filesystems/sysfs.rst index 2703c04af7d0..ffcef4d6bc8d 100644 --- a/Documentation/filesystems/sysfs.rst +++ b/Documentation/filesystems/sysfs.rst @@ -120,7 +120,7 @@ is equivalent to doing:: .store = store_foo, }; -Note as stated in include/linux/kernel.h "OTHER_WRITABLE? Generally +Note as stated in include/linux/sysfs.h "OTHER_WRITABLE? Generally considered a bad idea." so trying to set a sysfs file writable for everyone will fail reverting to RO mode for "Others". -- 2.43.0