From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A883D28000B; Sun, 30 Nov 2025 19:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764531763; cv=none; b=VpstN+lrVkugOsWJQTtOzk5pyGjv1CWPYrHVEtGCvISM9dRp+J5E4AjQMCHe40dJRJihSG6My6o3g/vebFphx+27fMaWlF3TAnf5/HkHz9LF4lfs3Y8YuEK0zjJ7nh979OUG0Kc03v0i6a4Nn1Qhzjo4vcU55kVmjOIQhUkISQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764531763; c=relaxed/simple; bh=UsyIcrAN+z+uloCc8uihm40ypzgGuql8alYATQbdSuA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C3tRIpruvfq5gcvyH2IfEEnuSWFG2Us/DmOhJwBoE6RBRHzggrshekUrdoyrkEwdN2Nwr3lmwHlBP4K+m0tWdNSm2cpEMNEse1d4KwQr4oRZdh6mTXs4YNp611Q3uWE8Y4SFHqrSE4p6vsmmChuBEYNn5t2QQV/Oqqg7PfTcnC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ccmizBMh; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ccmizBMh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764531761; x=1796067761; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UsyIcrAN+z+uloCc8uihm40ypzgGuql8alYATQbdSuA=; b=ccmizBMhLd+ImrOigbCMSo1IIM1ZlbCAgmArlPTq8Y0m4TOz3/9jo6xB 42mjq9Qq/z05vEolA2JfqeObxTtKN/vX7brB6W59d3OdbCOrJ/YozkrFz GhTohEreNfPx6KwhC24sL5+CGyaGsyqY9g33AcOZq3bMNvLjV3hm37aUs ILIgfWCg6Qn/Ab82ClfX2e0f7gTiXjDbshj8EXcmcb6geAWZPJ82Nr2Ng dRH/JFN+wul3zRqpc27QksRQwQY00dYNjyNyKUCD9Hv/o67t7O2KG+gSh rMIRC+Oegz4CaJr5Y6moNEIgLcv4euzZ8lDYi/aWuox0kXa8/2rCdltLI w==; X-CSE-ConnectionGUID: KPCRwvZ6T+CggV99T2bnkw== X-CSE-MsgGUID: AyDPfY40Qb6XXyy+U3XCSA== X-IronPort-AV: E=McAfee;i="6800,10657,11629"; a="77157984" X-IronPort-AV: E=Sophos;i="6.20,239,1758610800"; d="scan'208";a="77157984" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2025 11:42:41 -0800 X-CSE-ConnectionGUID: fVhBquvTRZKpmJKKTi5zYg== X-CSE-MsgGUID: zsOrzZCbR22wYU9/90Mwmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,239,1758610800"; d="scan'208";a="198231469" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.125]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2025 11:42:36 -0800 Date: Sun, 30 Nov 2025 21:42:34 +0200 From: Andy Shevchenko To: Yury Norov Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Randy Dunlap , Ingo Molnar , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Petr Pavlu , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] kernel.h: move VERIFY_OCTAL_PERMISSIONS() to sysfs.h Message-ID: References: <20251129195304.204082-1-yury.norov@gmail.com> <20251129195304.204082-3-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sun, Nov 30, 2025 at 01:27:45PM -0500, Yury Norov wrote: > On Sat, Nov 29, 2025 at 10:24:48PM +0200, Andy Shevchenko wrote: > > On Sat, Nov 29, 2025 at 02:53:01PM -0500, Yury Norov (NVIDIA) wrote: > > > The macro is related to sysfs, but is defined in kernel.h. Move it to > > > the proper header, and unload the generic kernel.h. > > > > Tough guy :-) > > I hope it builds well in your case. > > > > FWIW, > > https://lore.kernel.org/lkml/20220603172101.49950-1-andriy.shevchenko@linux.intel.com/ > > https://lore.kernel.org/lkml/20240212115500.2078463-1-max.kellermann@ionos.com/ > > https://lore.kernel.org/lkml/20240215093646.3265823-1-max.kellermann@ionos.com/ > > Oh, OK. Surely I didn't want to undercut your or Max's work. It's not about undercutting, I referred just for your information. > Do you know why it wasn't merged in 2022 and 2024? I have no idea why his (shorten) version of the series had been ignored. Perhaps wrong / missing Cc? Also he went too far on splitting things, and IIRC I mentioned that to him in one of the review rounds (but not sure). So, I think you can take his work as Originally-by: and modify accordingly. > > Assuming it builds in allmodconfig, allyesconfig on x86_32/64 and arm/64 > > Reviewed-by: Andy Shevchenko > > It seemingly builds well. Thanks for review. That said, I'm totally fine with your patch as mine at least didn't build that time. -- With Best Regards, Andy Shevchenko