From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8050C3396FD for ; Fri, 19 Dec 2025 12:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766148351; cv=none; b=eEJaXZsh0+KcEhYK96/n9++wI6iSMeLOo4O/Op4vIGA7lAQVb471JljKz1jEgF9LeQdDpWo+09vexbV2kAb3f71I5o85bC0bkHbdmndV8Ugxrqmf7+jtaltDoah25C5M+Ui3uQIiEORG+HgVe57D4NTLQKe+g/yCdccXMnrP3vk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766148351; c=relaxed/simple; bh=rSL621rykIUEPUs9lqTSuM839KvPGrjZGBWPyNzT8tY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bcj2WnlrubDPRED4ZFlWY3Nksog+iNdmLNW5T71kF/GCifHVmQhaT/P90WDchd8Cs5q0Usc1A9DLJ+X65SH0ttKGCGMVJdgbVwyy2zJvXu3rOUKa6n/1GSBJHB0eD5vOCNql/ms5Fula3ZVxVPO8xr6JDUuraHIA89Vg9qTWRrU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eQpkga8O; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eQpkga8O" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42fb6ce71c7so1381083f8f.1 for ; Fri, 19 Dec 2025 04:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766148346; x=1766753146; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ReSbGlU8XRlW0YyM9RKHmUTpdJ2dyefmPFjmWe9yo0c=; b=eQpkga8O1WWXNCP4aoXHqCIbJ7gVwsSLHneGuSdfbPjlLtZGuQrLS1bk5ZO3JadWQ7 CLmK8PjcYTDB+DI/KHO3qEwwZPmBq5T1rClsOdv0l48G1b6CLpm96i9ZYU6lnCwOxSGD GuhfxmmDP4uLBgDPZ4BQSdRTDZCzRQ6u0YH6Dv7uxhDMuy+8+aUZp4bipKlgDp6ya8qV slcYmam0D2aCKLp4J3yafWj8gNzDdvNghzyqQOka7rkjC4E/1hnLSRu04tNBZ+n3OeAA BuD11SK3744bzAQir9MOzWRcoZ8mzVh0vb0DMHM5HUVDfEZZuq+AyzTKydtrvlksOouV eJlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766148346; x=1766753146; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ReSbGlU8XRlW0YyM9RKHmUTpdJ2dyefmPFjmWe9yo0c=; b=wBS54+yE2MyNak4OzFEu9JbbaDSXkpHwrXbzu4IC/BWfXm/VofSdcUKsOgREMKTFsc +e8TqEh7shm0TubVnFNRu+kuAwazp9v5Uq+1IzePeDLz8yBfGiwIFxePodfnYsb/U2RR OzvdbcSalOjP0S5Eli6qtC85vpCv9C+C3x8QiOdYd/wqMvnRCLLwxkixpKWcFdAmOwGM TFTZYx3aWMMeuy61hy64xiiUsh3bcqan1Ak2FAbz5UQoemoHdyhYD955AaLuBAFtQu3s vA0zJGZdKOVGDfIUeWiupLTXtnwlFT7GmzAizEFthHcFb/U57Lv3U/i5fFYTi9Z6Kf/7 QT2g== X-Forwarded-Encrypted: i=1; AJvYcCUoEmKqYX85/Ai80UghgOzM7PJa1W5WM7+gQnbftCn4f7gF0CARTvUIvb25xKNOmeWUf4eQFgbIOiMxOBB2@vger.kernel.org X-Gm-Message-State: AOJu0YzFZOdSWgG7ccIe2y8HKRLOq2LJB23Kk+8dfvzoAL4kxCQvZk+2 flpQfyv/nuOswiUjFnys3jJ2R0re/LH38D7xl2N/kjlKnnJMHycLSku80JW3dZ/Vpj4xq7TM0TP TeuIf X-Gm-Gg: AY/fxX50u2oa8n9/z4dR74moiGKLgX5YN6Xtgyam9GxtjNhev2PtG7TDB+Qy2kr8a9w lRJkloRK3GVNm2G+81V+vzFg7zU5aW0/HTPaQ59wDcLVsISVUyB4WJUxtyY3u9LRYuRNOmzwJnE dPxx7gG1Q3fsSBms7yHJ8dm0oRPJXVpN56IZs84LhxO6ENfnpzKAF5enuUhZ4G+N1q+CzLWpMQW ppI3vMVPSQRAbKi9lYRnyzVV0ESKoFopXAGOjYBpbHRKru0hAbRGNUpTbtXsT0geVpJV1qJ2/rp 8hNeXynhPHAZE19YaVGHdXoW3N1F3cR5XiO0GDGFhaHQU1vIrhe6KL4Ep43wJ+kzb/OgIMbJ4Vz +irf61v7NI5IeC/HNf7+IFNChXb4dxPGyLdQgqtjGvxo970lCUWVP6qD2MUZlcVa2PiY5D9zp9X RKBDKeOtVN/6MGa2kN X-Google-Smtp-Source: AGHT+IETZ0G01z1cE7qdPgY5yrMZkHUa63bk9+h/z7utiQB+7f6R6xnjXPBJ2pNhG2GNw9+omqfAPg== X-Received: by 2002:a05:6000:1861:b0:430:fa9a:74d with SMTP id ffacd0b85a97d-4324e4ca445mr3427880f8f.24.1766148345817; Fri, 19 Dec 2025 04:45:45 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1aef7sm4702525f8f.7.2025.12.19.04.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 04:45:45 -0800 (PST) Date: Fri, 19 Dec 2025 15:45:42 +0300 From: Dan Carpenter To: Daniel Gomez Cc: Sami Tolvanen , "Luck, Tony" , Chris Li , Eric Biggers , Kees Cook , Luis Chamberlain , Rusty Russell , Petr Pavlu , "linux-modules@vger.kernel.org" , Malcolm Priestley , Mauro Carvalho Chehab , Hans Verkuil , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , "linux-hardening@vger.kernel.org" Subject: Re: [PATCH 3/3] module: Add compile-time check for embedded NUL characters Message-ID: References: <20251209001139.GA7982@quark> <20251210010020.GA2522829@google.com> <083ebd92-4b3f-47f8-bf0f-395a604b5f05@kernel.org> Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <083ebd92-4b3f-47f8-bf0f-395a604b5f05@kernel.org> On Fri, Dec 12, 2025 at 02:30:48AM +0900, Daniel Gomez wrote: > Maybe the flag fix just needs to be applied to the evaluation? Other op > structs do the same. But Dan's patch did not implement evaluate. E.g.: > > static struct symbol_op constant_p_op = { > .evaluate = evaluate_to_int_const_expr, > .expand = expand_constant_p > }; > I was waiting for you to send this as a patch. I can do it if you need me to. regards, dan carpenter