From: Christoph Hellwig <hch@infradead.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: mcgrof@kernel.org, petr.pavlu@suse.com, da.gomez@kernel.org,
samitolvanen@google.com, atomlin@atomlin.com,
linux-modules@vger.kernel.org
Subject: Re: [PATCH v3] module: print version for external modules in print_modules()
Date: Mon, 9 Mar 2026 23:31:28 -0700 [thread overview]
Message-ID: <aa-6wILF90Y4ndnd@infradead.org> (raw)
In-Reply-To: <20260310023807.80140-1-laoar.shao@gmail.com>
On Tue, Mar 10, 2026 at 10:38:07AM +0800, Yafang Shao wrote:
> For vmcores triggered by a driver bug, the system calls print_modules() to
> list the loaded modules. However, print_modules() does not output module
> version information.
And it should not.
>
> Across a large fleet of servers, there are often many
> different module versions running simultaneously, and we need to know which
> driver version caused a given vmcore.
Then don't run extetrnal modules, which are not a first part citizen.
Get your changeas upstream instead of just leeching the upstream
developers work.
next prev parent reply other threads:[~2026-03-10 6:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 2:38 [PATCH v3] module: print version for external modules in print_modules() Yafang Shao
2026-03-10 6:31 ` Christoph Hellwig [this message]
2026-03-10 13:04 ` Yafang Shao
2026-03-10 13:07 ` Christoph Hellwig
2026-03-10 13:11 ` Yafang Shao
2026-03-10 13:14 ` Christoph Hellwig
2026-03-10 13:19 ` Yafang Shao
2026-03-10 13:21 ` Christoph Hellwig
2026-03-10 13:30 ` Yafang Shao
2026-03-10 13:33 ` Christoph Hellwig
2026-03-10 13:35 ` Yafang Shao
2026-03-10 13:43 ` Christoph Hellwig
2026-03-10 13:44 ` Yafang Shao
2026-03-10 13:47 ` Christoph Hellwig
2026-03-10 13:49 ` Yafang Shao
2026-03-11 22:44 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa-6wILF90Y4ndnd@infradead.org \
--to=hch@infradead.org \
--cc=atomlin@atomlin.com \
--cc=da.gomez@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox