From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 804B331A56C for ; Thu, 29 Jan 2026 14:41:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769697709; cv=none; b=lYwYoqZHYJstrgVEXe1xwWZlMZ1JhtF6nUMxpVQCgmgmmd8JBrOglWsk6nm89aX/0h/OfB0NJCpSn98HceKXHnuja2kP8rvLMMFYI6v6zJP/M2HpbY1wizzLG5xQR/0qcISxt8rCO/pDZb+XODUK7NAT+labfobsSBVTXaBEktU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769697709; c=relaxed/simple; bh=F0b8hnfWHbsOvhccuNKow2wnsDEWWek2mfssz8GMxsU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lLrS96cdAz2Jnx3JuLVVJ1kv2tykVa17383i42FABykbMvv9UuWdIEfaex4NVdmNbRHXFoadwZxhyeyAoeh/oiwTcYc9o3U8McRAoTwYHqnNxY5DwWYiz6v3QGac9UMzZehquCRLjoI61GTIqwRuFNKf3H7br0qDC7DUNLM2e/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=DCdmfDvY; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="DCdmfDvY" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-480142406b3so8047875e9.1 for ; Thu, 29 Jan 2026 06:41:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769697706; x=1770302506; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RiXqWFBbTqasdWh8G25vCefiMtu7P/aKonwdz1Q+QEk=; b=DCdmfDvYjNE7C1O2jiZtSAx5VFyXp7kD/Q7BI5euaOR+Aece3eGzUKs2VWuSK81cFV 1GFRfcCRI5Gukv0bp9TizXNuyZfwsTpyqy5P+VkNyNxkRnws1AEIYl2hhEUd8UPa0/PW y+3TgGZgtrKtkyDwNhatNcP1EY9CAYjT70lD1b7Fs8UyFAO/WOJh+HnBMwFvQxOZlZBz QuNuFBwZImsqcYQ1MDZ/A8alCPRdprBiX4rjuvwJ24bIc5V0PHY1wJV1+QrbSDS7TFwP 0REI1tXsfsQnH7ryQMfgAhS9va5/2Ax1ONsbMHGzdnpe132FZc+P1kz/N4aylIk7XgMh TwAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769697706; x=1770302506; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RiXqWFBbTqasdWh8G25vCefiMtu7P/aKonwdz1Q+QEk=; b=mHSWS3/I8hX1GS/KT6kSAWzpObNSaZRLs2HOTwvOTt+bxApdfCzcfMPs5gE2JxLMR5 OOx1EvWM5uu11r4LolMwm5S/UqIzkPjsHR6CJIETxVlcqOSCDHpurDEMJDz7qJyVvmwZ pbJ8c4vBfTeBEMk9AiArxnXbYOhClmAKpmETg+qj09En3pVU/iYKjtnntdVFiTPvFcra rHdfTQAucsI/yoZ0CQHmotP6vgJC9gYxXfZ30G5+JUrH6DaZ2uj4Bu+2RrB9B/EN1OxG EtzAH977zmyTT+uLQ0f9AA7ZUebhJnwrKzrFURKJbRkrL/74PGaY83qkdS8TUdo17NEJ THwA== X-Forwarded-Encrypted: i=1; AJvYcCX/j6keLVeYK5es38wJZZjX8rmzwGPwknLyjhynPvvMhE3DNgkDrAZq/klUkesvYVKymRBSNdstL57O2RGb@vger.kernel.org X-Gm-Message-State: AOJu0YzqKkcwl0L6bNhgy7U71peXT+GiPxr2LFZfRaN1HOHqyyOlUVF5 lQ8fleIY6qFnX4TzBqYukBB/8Tuk2MM8qJZ7g3ldC+erZW6JKVEFpYqBAA4zAmGWm0E= X-Gm-Gg: AZuq6aIeleMv1mqn/0mE9GYJ/wbqhed2hGnBnxmm+uetOmGacSNQKyDRHiS+Hvl1VTy r16BGKuhpHJZTRd1xB+oM48IuO7E/Rv3s/1OcEtvhRLx7cwIpHgwnxd4ABiFT/AEXnaSb+a+5yy odYndinihZT6ToL1D73vTWw2XArCAKA61+A2foBNwlZA3SjdH42SURUGaVzUOAyAn69RSaTlUVa N8Mp4/B/jyF+2Y/AsFiAN3UVqw9rdOIuzV9o73DncvDv9l7g3JJB8MWSKDzDY8kxYcMnL3AofI6 nNZlq/41lLGIxbn6f2fo9JO7iN03aFQVXHDQCLbirGgYVDxIXY2aU0sOBF0G4EE1s6a7JZ7ajpM mtG5SH48Fzj2V/DOejw6NSD/NhCZkTO+lE/wjO8mj5tXfFsM+zIawObI17Dsx8XoG7seSsh9De5 Kr4EnEx0WHJZzi5nK5m2RnPnXLUCEOfg== X-Received: by 2002:a05:600c:8b76:b0:480:2521:4d92 with SMTP id 5b1f17b1804b1-48069c49d54mr120114805e9.24.1769697705735; Thu, 29 Jan 2026 06:41:45 -0800 (PST) Received: from [10.0.1.22] (109-81-1-107.rct.o2.cz. [109.81.1.107]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c37433sm182396725e9.10.2026.01.29.06.41.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 06:41:45 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 15:41:43 +0100 Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/17] module: Move signature splitting up To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: Nathan Chancellor , Arnd Bergmann , Luis Chamberlain , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Nicolas Schier , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Schier , Nicolas Bouchinet , Xiu Jianfeng , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?UTF-8?Q?C=C3=A2ju_Mihai-Drosi?= , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org References: <20260113-module-hashes-v4-0-0b932db9b56b@weissschuh.net> <20260113-module-hashes-v4-12-0b932db9b56b@weissschuh.net> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260113-module-hashes-v4-12-0b932db9b56b@weissschuh.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/13/26 1:28 PM, Thomas Weißschuh wrote: > The signature splitting will also be used by CONFIG_MODULE_HASHES. > > Move it up the callchain, so the result can be reused. > > Signed-off-by: Thomas Weißschuh > --- > [...] > diff --git a/kernel/module/main.c b/kernel/module/main.c > index c09b25c0166a..d65bc300a78c 100644 > --- a/kernel/module/main.c > +++ b/kernel/module/main.c > @@ -3346,10 +3346,21 @@ static int early_mod_check(struct load_info *info, int flags) > > static int module_integrity_check(struct load_info *info, int flags) > { > + bool mangled_module = flags & (MODULE_INIT_IGNORE_MODVERSIONS | > + MODULE_INIT_IGNORE_VERMAGIC); > + size_t sig_len; > + const u8 *sig; > int err = 0; > > + if (IS_ENABLED(CONFIG_MODULE_SIG_POLICY)) { > + err = mod_split_sig(info->hdr, &info->len, mangled_module, > + &sig_len, &sig, "module"); > + if (err) > + return err; > + } > + > if (IS_ENABLED(CONFIG_MODULE_SIG)) > - err = module_sig_check(info, flags); > + err = module_sig_check(info, sig, sig_len); > > if (err) > return err; I suggest moving the IS_ENABLED(CONFIG_MODULE_SIG) block under the new IS_ENABLED(CONFIG_MODULE_SIG_POLICY) section. I realize that CONFIG_MODULE_SIG implies CONFIG_MODULE_SIG_POLICY, but I believe this change makes it more apparent that this it the case. Otherwise, one might for example wonder if sig_len in the module_sig_check() call can be undefined. if (IS_ENABLED(CONFIG_MODULE_SIG_POLICY)) { err = mod_split_sig(info->hdr, &info->len, mangled_module, &sig_len, &sig, "module"); if (err) return err; if (IS_ENABLED(CONFIG_MODULE_SIG)) err = module_sig_check(info, sig, sig_len); } -- Thanks, Petr