From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=212.77.101.11 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795094919; b=0iVCYr92EZ8HG0rRvRWCPd2QZ3o6CrEzwAD2LjdVtwRCIZw8z4pQdFP1VfVj0z2ZiyEa oKxcuTzf9osOLBWGTosYnBvXKPAi4OXEN2YPcF8n7NnD3X8/oehtAEyyRPfLIEiGlXmG6 QA/Ao73Uywp+pt3psnqaS+YmGeMWJ04N5vlHARj6eJ3pgvPWcvK936sz1s3jFS7cJipA1 hfcX54jDOiM08/xFbWZTxWybShvd6V/qh5af9YJr8SN+Begd1YD8vi2IRHwQPpZHlzcFM o7kFHddZzYZuUNLJFyB+QqnqjyrJFkfz+6oeOIrZ6E1T0RN6zS7IcP38jamnuvbPDig== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795094919; h=DMARC-Filter:Received:DKIM-Signature:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:In-Reply-To:X-WP-MailID: X-WP-AV:X-WP-SPAM; bh=nFs7LhyMy8k5jmGRKz1u70BSbgNhRCYabK2uhH/Xm0o=; b=pMpOMFZasLTUIv3ahFjqhYje59/TXqF8PB9krwgfjA2eovLIVqOJGUf2REJAKJaTiV1C zXR0pFKsiAF5JQWQj+KBd9h8dycRlBnLH5aYcxUwGKhxtMCzZfXq5UGLaeuptBfKUfBad cRuxBAKHXPM0QNyLCrNPl9xYSf1Nu8sS4CqWF8DVpJkAMEecHuFWpvUNApcF7+jtjR6Da vksB2TKTIx5Qk6sglMOXKZ2c/2GtDgmHjPpKKoyRRUJOpF/VC3MabXjF5a+woGbAMJl8+ xW6SQLWZJz0cVvMrvQXmeA1QZUebHtHVc2GWw7R2SXk6ZOK0b9bi7hwmbbWz9lZ/vEg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=wp.pl; spf=pass smtp.mailfrom=wp.pl; dkim=pass header.d=wp.pl header.i=@wp.pl header.a=rsa-sha256 header.s=s20261001 header.b=V2TDVTkp; arc=none smtp.remote-ip=212.77.101.11 Received: from mx4.wp.pl (mx4.wp.pl [212.77.101.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60472606AA55 for ; Thu, 19 Nov 2026 13:28:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 60472606AA55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wp.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.a=rsa-sha256 header.s=s20261001 header.b=V2TDVTkp Received: (wp-smtpd smtp.wp.pl 40278 invoked from network); 19 Nov 2026 14:28:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=s20261001; t=1795094914; bh=nFs7LhyMy8k5jmGRKz1u70BSbgNhRCYabK2uhH/Xm0o=; h=From:To:Cc:Subject; b=V2TDVTkp6Twu60YGIv2NCg68IvYXBm+v+dlOqdyd/n5kGJgr51wVRE951Gash8RIs 62/x215GUrBT+jYp9l/W43PkAqXQUGT7pn/9yUUN/3Y8MAEc9GA6xXs4igFqLij4ix 0LsPtIfWP0u9JnWWd97zufqpUOKgxppFDcGP3sDIq3r/Ef/zhSdaQwE5u54lraiZXg I8YhZoQTCW+5R5EroEdhUC58nXkbDUMLEdTv9wSiPrrsCHwxzGpLoL1J9/z4hJTvBO jF+2IjGdHWzqP61HaFOSZ/bR0uH1/ioj0iUd4Qqa9wI28SLPJYY4weGVvvbSB6QKP/ DhUwwEUfL9wDg== Received: from localhost (77-236-5-223.static.play.pl [77.236.5.223]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with TLS_AES_256_GCM_SHA384 encrypted SMTP for ; 19 Nov 2026 14:28:34 +0100 Date: Thu, 19 Nov 2026 14:28:34 +0100 From: Stanislaw Gruszka To: sashiko-reviews@lists.linux.dev Cc: linux-modules@vger.kernel.org, Sami Tolvanen , Luis Chamberlain , Petr Pavlu , linux-trace-kernel@vger.kernel.org, live-patching@vger.kernel.org, Daniel Gomez , Aaron Tomlin , Steven Rostedt , Masami Hiramatsu , Jordan Rome , Viktor Malik , Petr Mladek Subject: Re: [PATCH v3 2/3] module/kallsyms: sort text symbol indices and use binary search Message-ID: References: <20261118145125.29399-1-stf_xl@wp.pl> <20261118145125.29399-3-stf_xl@wp.pl> X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-WP-MailID: 783790f8ec710f57db30d5bf09b3768a X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [kTPk] On Wed, Nov 18, 2026 at 03:02:42PM +0000, sashiko-bot@kernel.org wrote: > > +// static void pr_tab(unsigned int *tab, unsigned int n, Elf_Sym *syms) > > +// { > > +// int i; > > +// // printk("\n"); > > +// for (i = 0; i < n; i++) { > > +// printk(KERN_CONT "%d,", tab[i]); > > +// } > > +// printk("VALUES \n"); > > +// for (i = 0; i < n; i++) { > > +// printk(KERN_CONT "0x%08llx,", > > +// (unsigned long long)syms[tab[i]].st_value); > > +// } > > +// printk("\n"); > > +// } > > +// > > [Severity: Low] > Was this commented-out pr_tab() debug helper left in by mistake? Yes. > > -- > Sashiko AI review · https://sashiko.dev/#/patchset/20261118145125.29399-1-stf_xl@wp.pl?part=2