From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 056423D47DE for ; Wed, 25 Mar 2026 12:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774442973; cv=none; b=k1t7PgW7Ekfph1I6wTXbblhXfl1wHckEvqt/tTMi2Kuw0d5nI4vxSciAFpxG6+M5UP6Z+0zSWLdNL3qnbsTexOjTus3j3Mr8UQ3daIYrA3SZc3o1OVaYCwBYKrSpjb6JFQtRMeBMLIVBHgzis+cq5TKav3xUSsrsYwvwDU/TzrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774442973; c=relaxed/simple; bh=0jbWB3FjVQp+P8Ybiw1JdATIo1RfpVsEkcvfvEH0fIQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cdi9rQmP6okhycaXqcUbZH5UM6K9DS46djxiqaf120pdKnbaeHnCfj2OO90B+a+Na2UQ1e28fLpwEtsbDgJp/p+eEUvHAva/0MgzQj5SwwOtymEFwcFsLa0chVVQlQKAZi9gq9Sa25/KPL17QSjxymsBnbDiNA7HmNrSR7jSD44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QsQTBQ2R; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QsQTBQ2R" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-439b6d9c981so609323f8f.1 for ; Wed, 25 Mar 2026 05:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774442970; x=1775047770; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BJ4RwDdYC7l5LX4+kxPiqchKwdT0zRAfuYVx8dHTGTI=; b=QsQTBQ2RkrQE7IMnUQFMVZf91MzfH5VhYOdj1f6Kc0qHkUjbpodcFhfNqvP7j00lIL 7+0NS3ce2sJFLeV0zP1vFfjxIhzEfBOaUThEj56njyTJBz08hVYC3GsWPreyMX0/s+SI bqiSjb8e/MteSBDYDfZ88BtS+5N4oP3+lCjFDol0aDha2po5mM/macY7Gqc9+Qj7BF1Q Q9kC8G6jUxbYVPT/E3pXanzVD1QenpTOeoh5HahyBpCrlKLC34dPfa3dBGd4ozO0YZsi 7nw+Vgi2bbhvnadrOePJ2jhdU86tkN+eJJiNDLdUr890bBTyvTbkDcI5FEOSvJZkri2v oHGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774442970; x=1775047770; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BJ4RwDdYC7l5LX4+kxPiqchKwdT0zRAfuYVx8dHTGTI=; b=Tjk/SP0DA3kJ2TMcpNFM1NHiXJDLrKvyBX6sATbQgbqzUes4sty4Q+4tLOsC5E/0Us 1anXP2lNut9p1rE6GERGCdIJBINusQXID1BlrvzNK8dhFguqEkqnpzvVcdLNnVoDQiU7 bBdDMLnAa73edFbzSrUOnDFacpa1limgtG2rMP0w5fKXIBcBfYm+wDdXHWsYTRoc36QW O54KGJawMD0RcanU4d9GwXPLPYXiJ74lpu1yFtdtko3hsZzHRTfSWW4i3eVSPqsiztK2 4fI2OuK7U5oBN4tE2JjGm8GVGvXCWN4tiwlv/z/o6eUhEr5lXDks/huoMkPBUIDyFe9b VPPQ== X-Forwarded-Encrypted: i=1; AJvYcCW5KcnYUnfd+OVI//ZVuLgBqwHDJAJTFgz+srndGkDXIJ6DTcQJKFm9LVK4wqQx/YWPlN+aHew9Clz3Znky@vger.kernel.org X-Gm-Message-State: AOJu0Yws6oA8R0z9+sS4Uc9r5fAFIgFKKoxTMrdKXLA2Qh4TwqSyzHGI 6m/jCksWSqiY23nRO0RQDBpoG8ZxeZicM46iZ+8Zl6n/oogRxETeDuZXzhzBisZBF+0= X-Gm-Gg: ATEYQzwURTGMLg301d1gWQkRlm6MOqOkAlHeEIZ31ieEyyPRozp0MRx8/fJXIEXGL07 RAIxJ2RRGZdEPQK1KIo8GZ3CDQALzJNexngal9fo9+OSsA10aYFAZADfBvoQpOgJGsZJzQClQY6 MrgFq3XTQLuVMmMZWWjtWLbwDoQCzszWWtxXJCz+/KHtNasFg3gDL9/NbcCe9KAerlfY0/6F2EZ v1SivbP0pnRAcnszxmlH+b3XcTJaBAKV/zwO/TOqh1wLnVcbAO2fryCqo7skcEACAtJbYs4jWlC U8fx8OqING/DqYUvmRecsMvg91St3FaxtQS9x2U+QAWGyp9nQLFaTBZwKk1Nn9JdgHn/paJazJ8 FUo516QpzndBHWKSaO5iKq4rB9Xw8Ql5PFNz5Z2vH31V980Xna1rVMzS1huyFZQr2RYmzssaLqy 8LQbtDhpDVE/cYvTpGupaLngXp4kWVU4csuZbtBR9Inb2D X-Received: by 2002:a05:6000:228a:b0:43b:4909:203c with SMTP id ffacd0b85a97d-43b883c881dmr5791312f8f.21.1774442970332; Wed, 25 Mar 2026 05:49:30 -0700 (PDT) Received: from [10.100.51.209] (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b8508285esm13445921f8f.19.2026.03.25.05.49.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 05:49:30 -0700 (PDT) Message-ID: Date: Wed, 25 Mar 2026 13:49:29 +0100 Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/8] scalable symbol flags with __kflagstab To: Siddharth Nayyar Cc: Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Arnd Bergmann , Nathan Chancellor , Nicolas Schier , Jonathan Corbet , Shuah Khan , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, maennich@google.com, gprocida@google.com References: <20260305-kflagstab-v4-0-6a76bf8b83c7@google.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260305-kflagstab-v4-0-6a76bf8b83c7@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/5/26 5:55 PM, Siddharth Nayyar wrote: > This patch series implements a mechanism for scalable exported symbol > flags using a separate section called __kflagstab. The series introduces > __kflagstab support, removes *_gpl sections in favor of a GPL flag, > simplifies symbol resolution during module loading. I noticed that the series has a bisecting issue. The module loader doesn't see any GPL-only exports after patch #4. I think you'll need to squash patches #4 and #5 to fix this. Alternatively, the patches could be swapped, with the caveat that GPL-only symbols would lose their GPL property for one commit. Nit: Please use simply the "module" prefix in commit subjects: #1: module: define ksym_flags enumeration to represent kernel symbol flags #2: module: add kflagstab section to vmlinux and modules #4: module: use kflagstab instead of *_gpl sections #6: module: deprecate usage of *_gpl sections #7: module: remove *_gpl sections from vmlinux and modules The changes look otherwise ok to me. With the above fixed, feel free to add: Reviewed-by: Petr Pavlu -- Thanks, Petr