From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF6491B0F0C for ; Wed, 20 Nov 2024 14:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732111902; cv=none; b=nSQhHxw4smZ0F1VHbJIg9bzwcuEyd4nIHj6WRZPuXzQFMqXxRsiLlhLJWhmA3BndfR9WMOMks7jmoznPjsppTrjZiChXlcdXfeKHp1KF6I4fxDAHHmg4Y3faAo7Yp7J7jlW67vCTvKcsKxjbKl+MjFl/lc/vX1aaqUb9u5pgQ4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732111902; c=relaxed/simple; bh=FfUNXLNLMYAUKNxyY8yLvAOSk6II0QVXiht1oJ/aXwI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JJ++QkodpbQs0+u+hDIc6mGpOPz0R3JiuGZMt3fNWHJ5+TWCJtTpaA2PxFsVtyVuHaVUgP+pVEc6whoLS1YsC7BmYvhVJFeQkCUSmqHLPZftrBcOdRnBfJ4U6feeKIJcp0BY5xnwvArKgKse8ZgNgnA4QUtzQBD9WCuGB2xki5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dOKoK2g4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dOKoK2g4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732111899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r1HheHXxH2Lq66Pb3UAs+ct3ExAz5ElR999iJ69jx0Q=; b=dOKoK2g4OJ/9SsbASuYG0q5EjcEwmMtuv6XUihIKbgDD1QETStLQwWMStbfN8kQ/0nFhU2 dhJl6RQXYjjL/oeQn29UlTIFh9mZDAJe/tr9+bFgd5dGl2HhBNOr6INEFczH6goFXcSjJ6 rYMEPFRXU1hrpTCS6EA9ZvUi4fqOII0= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-Dw9a1a2ZOWObXtKByxDuYQ-1; Wed, 20 Nov 2024 09:11:36 -0500 X-MC-Unique: Dw9a1a2ZOWObXtKByxDuYQ-1 X-Mimecast-MFC-AGG-ID: Dw9a1a2ZOWObXtKByxDuYQ Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-5cfff755da9so253118a12.2 for ; Wed, 20 Nov 2024 06:11:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732111895; x=1732716695; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r1HheHXxH2Lq66Pb3UAs+ct3ExAz5ElR999iJ69jx0Q=; b=Q3GA+VAuSv08oh8yQFT5/pv6wAJfONfm2vdOTaaNIYvsiP92oJunXHx5vO1P75N6/G 2EWsQqp/vRk5lP8nYaUExT6DnMvf7r6Fb4eTwvngKoBUtCxWE7+8TEw+bFWNkApjFLUQ xeYFkyzuRYIDKOJBmVvHCztyitiRAU+sluq3482Ok++vmp5TP6p/4fxGNffnEe6sDeuX +Zl+dmOCkyK9eTmEvx+dMgSazP5qhAF5xnr7t2EggOcJdkAHqHl7ONniukLvRXMI6d4+ aJhSPqADXeTNzepAnAlP7GmC/6btxHyjz7BJYfah0xZuOchB6ltaBOzzLBibA9RUzrWs ZU8A== X-Forwarded-Encrypted: i=1; AJvYcCWlXchev41cZQx4R2M/WTAGkRWswhYuOYZCJtCpk2guaAwMnctsZciyBonczBvm2DfM+Tng8X2Fz9xwJMPs@vger.kernel.org X-Gm-Message-State: AOJu0Ywen7QAHCNVYUBnvZpp1Snu3BtjeRwFHMAZh+YgnfuMffPEnFX2 ho+J42cAIHCj7xsb2JBDO6gEX0q/8Rhk+1ESi5PzfqiXlRKn8aUMs83KTORM5yhtCNiWl9sHJZ/ PYwMeIGUDyz7Bojett1Leou512en36U3Ef+gOeOPbCksY8KuV7b8TCnO49GGAu2c= X-Received: by 2002:a17:907:971d:b0:a99:c9a4:a4d5 with SMTP id a640c23a62f3a-aa4dd57cf5amr307473966b.29.1732111895283; Wed, 20 Nov 2024 06:11:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IElPsBJusCgQQSy0/ZUamPrIprvapmeW+J3BVJ72fqi1ZqWyGC3oczhgmzOu6DsZlUvs2u7Bw== X-Received: by 2002:a17:907:971d:b0:a99:c9a4:a4d5 with SMTP id a640c23a62f3a-aa4dd57cf5amr307470466b.29.1732111894916; Wed, 20 Nov 2024 06:11:34 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20dfffcd4sm774935966b.98.2024.11.20.06.11.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Nov 2024 06:11:34 -0800 (PST) Message-ID: Date: Wed, 20 Nov 2024 15:11:33 +0100 Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Luis Chamberlain Cc: Werner Sembach , tux@tuxedocomputers.com, Petr Pavlu , Sami Tolvanen , Daniel Gomez , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Thorsten Leemhuis References: <20241114103133.547032-4-ukleinek@kernel.org> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20241114103133.547032-4-ukleinek@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi All, On 14-Nov-24 11:31 AM, Uwe Kleine-König wrote: > Hello, > > the kernel modules provided by Tuxedo on > https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers > are licensed under GPLv3 or later. This is incompatible with the > kernel's license and so makes it impossible for distributions and other > third parties to support these at least in pre-compiled form and so > limits user experience and the possibilities to work on mainlining these > drivers. > > This incompatibility is created on purpose to control the upstream > process. See https://fosstodon.org/@kernellogger/113423314337991594 for > a nice summary of the situation and some further links about the issue. > > Note that the pull request that fixed the MODULE_LICENSE invocations to > stop claiming GPL(v2) compatibility was accepted and then immediately > reverted "for the time being until the legal stuff is sorted out" > (https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers/-/commit/a8c09b6c2ce6393fe39d8652d133af9f06cfb427). I know I'm a bit late to this discussion. Still I want to point out that Tuxedo and especially Werner has always been a good upstream actor and I do not believe that they are operating in bad faith here, but rather that the GPL v3 licensing is just an unfortunate mistake which is hard to fix after the fact. As maintainer of drivers/platform/x86 I have worked quite a bit with Tuxedo/Werner and their contributions there are much appreciated. They have also helped a lot with sorting out issues with the PS/2 keyboard driver on Clevo barebones covering not only their own models but all models and helping out with cleaning up the quirk code there which was getting a bit messy. Also as you know Werner has already relicensed all the out of tree drivers which Tuxedo could easily relicense to GPL v2 to GPL v2. TL;DR: I do not believe that Tuxedo/Werner are acting in bad faith here and IMHO it would be good to give them some leeway here while they sort this out. Regards, Hans