From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 016454343F3 for ; Fri, 10 Jul 2026 15:58:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783699133; cv=none; b=bguuSheFEaDOFduB5UojMmouWkmyVeDDJWamWukDSFLxrYz535+XSBZ8iCjA5GbxBzNZG9VDoAs3aBiUsudHT9tXYLVmNnSpDo5AK9C94mJAUaA15JGG2AGPttDRI6UwuKyuuZBXbzsGyl4/WQWIo/vWOA5GK1A/jpr7qVO/NK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783699133; c=relaxed/simple; bh=0OTiTiVSo0IDemovGfT3is8+e+GAuZ+PEePU+/MbCSk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pOc5ff1g5/SGOsYmXotw2wJhqqOoiqLFscdjnBu2TlABE3WNXdyob7DiUZOg/9ljaH7QvlCV8EpfVNoQa8LfiE5eJn78g6oqdzJymtmj+VgF6bOnPjH12cTiItTfRGFrPDXNfUHsWyDwvkqviCUKLfQNxd5XHksY0z5/3s55llY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=WmpG8nVe; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="WmpG8nVe" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-493f4638f4aso8584215e9.3 for ; Fri, 10 Jul 2026 08:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783699130; x=1784303930; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Luf6olTEAQbJ7p+MoI/MDGQDIrig7h+9ncRK9wup6Vw=; b=WmpG8nVeD4kja5GqdytCXA5nuic9I2Ry70NaevlPn3gWJP/ahnSYXfv5vkTuLGBmPU 5Q8D6OWrUkjsrKlcO7WTbTaIpCUrcgd43GMwJT28Zq2uTkp8iKnnej2DvyawENAu1DtV +zS7latUwe9hGSfd/hhpgkENCb8/udqQi/PEThS7ggETqJDiQdnT8R1aZUNbAm2q2Sg3 XgivlXdqgJsl1IdCv6IlxiDx/N7vtM+OiPSJ3T95ZYbXJz5mmnJyWrRD1W6Y2FI/BOkx SBCjVeLr7OzlY2mPA54Bg0SDioVuWutC/LNJSLP+uUiuyLilCn8BtQtiC/KZ7/w5AiSI Nhqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783699130; x=1784303930; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Luf6olTEAQbJ7p+MoI/MDGQDIrig7h+9ncRK9wup6Vw=; b=bGwi2bJBLKv7+NhISMdwd1kRqaCqTWZze0Jg9fs45d1wLhNA3flLctHx5n3sbe42nl znp9c/a/wpEf8CAAeKnsPvVvjdREvBae7doXeQqFDyx9opzyuDPS09oQ9Q/kKcNa6enZ 6vdU53KGuXDNhWgdBzABJ66+ERC2XFVCrxnqoVqMcJ2n4+O0JRZeAGd1pHXUZunikZo8 BS+0FmQDjOMAE7YBtM3/nnjGCD8/4NwnZU+Dbhzay2BFpjuC4O7JTcqVg9O9XZ6e3RBx DNZxauH/NTQTHt2v3wOS/2jf8joUR6ni/aqQ+V9dEuKnx4M7ngiHngD545IwUgcASZiW XyZg== X-Forwarded-Encrypted: i=1; AHgh+Rrdr0rTifNilQHQQIBkFgwsw4ReXoq207NMTyPCh73fz+OXK5vylA/jEolXRioZ8u8uxMezH8dnTX0NNVtB@vger.kernel.org X-Gm-Message-State: AOJu0YwBjCzHBxjAQq7Qu4rD4l3j+6jihFu4KEk2RVxKRKhKW1hjT/ac EWKy/K4IvsNwLy9w55wi/zszG+Ivu4V35E9f6fKFJUcpaS+GOU32t7aIEBKBMmBaBMg= X-Gm-Gg: AfdE7cm+EcpA8Xxz1Z9XUqiDuXCahEKXXVfdAG1LDpCA9JQhgaOZceTHIX+UgEI8ts0 LiZ/GTiAZDGMF6U4sKFwwzCmpbvSJipx1y86FnSc/kt3uXau4OpG1ywU4oUrE5tuGqu3Hh8EZvh 1y/fhTDQCA64xqHqYYnfROgAirty/X4fnRS5bpeRfFUQw/oLBYdBf33ZhSN3eRKn1hegkM6WXPr Qfi9K0PCWOUGBDkGvp9OhHq387fDHdK+ZT0OaV+crvWzKdPWqlltseLSxY/mEqIsckM/AjSnSL8 RVogJdoSPGaau+Z+6GzMdwM4MlNqyvmepWAtv8WlKH32OGcmckZuFfjoE1ifhOtHYsjA9F0Y1YJ 3WGWs+f8PIEriP9cZxT1xJzw9ftl+WXByMIL0yPk2W67cla2zlzN51qdsZsslYVdHCvXq15eT+F kn27EVoc3X134xibiaNzWYSNogThRfaW3sPQ== X-Received: by 2002:a05:600c:3f0a:b0:490:e974:e006 with SMTP id 5b1f17b1804b1-493e68e8195mr120330845e9.29.1783699130249; Fri, 10 Jul 2026 08:58:50 -0700 (PDT) Received: from [192.168.42.79] (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-744d6deb2a3sm5447229137.8.2026.07.10.08.58.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 08:58:49 -0700 (PDT) Message-ID: Date: Fri, 10 Jul 2026 17:58:44 +0200 Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] rust: module_param: return value by copy from `value` To: Alice Ryhl Cc: Miguel Ojeda , Andreas Hindborg , Miguel Ojeda , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Trevor Gross , Danilo Krummrich , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org References: <20260601-modules-value-ref-v2-1-12ebbf0510c9@kernel.org> <52feb9b1-2073-4fcf-b2d1-a7f42f1e72a5@suse.com> <30e500ce-e9e6-43cc-bbdf-ded7c0ae56cd@suse.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/10/26 4:26 PM, Alice Ryhl wrote: > On Fri, Jul 10, 2026 at 10:13:53AM +0200, Petr Pavlu wrote: >> On 7/9/26 4:13 PM, Miguel Ojeda wrote: >>> On Thu, Jul 9, 2026 at 1:48 PM Petr Pavlu wrote: >>>> >>>> @Miguel, please let me know if I should take this patch on modules-next, >>>> or if you'd prefer for it to go through the Rust tree. >>> >>> Please feel free to take it through modules-next, of course. >> >> Thanks for the confirmation. Queued now on modules-next for v7.3-rc1. > > I'm seeing this error on x86 with latest nightly rust compiler: > > rust/kernel.o: error: objtool: _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramaEB4_() falls through to next function _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramhEB4_() > rust/kernel.o: error: objtool: _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramhEB4_() falls through to next function _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramiEB4_() > rust/kernel.o: error: objtool: _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramiEB4_() falls through to next function _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramjEB4_() > rust/kernel.o: error: objtool: _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramjEB4_() falls through to next function _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramlEB4_() > rust/kernel.o: error: objtool: _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramlEB4_() falls through to next function _RINvNtCs65fqAZscXCv_6kernel12module_param9set_parammEB4_() > rust/kernel.o: error: objtool: _RINvNtCs65fqAZscXCv_6kernel12module_param9set_parammEB4_() falls through to next function _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramsEB4_() > rust/kernel.o: error: objtool: _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramsEB4_() falls through to next function _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramtEB4_() > rust/kernel.o: error: objtool: _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramtEB4_() falls through to next function _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramyEB4_() > rust/kernel.o: error: objtool: _RINvNtCs65fqAZscXCv_6kernel12module_param9set_paramyEB4_() falls through to next function _RINvNvNtCs65fqAZscXCv_6kernel6devres16register_foreign8callbackINtNtCsbtRzKR1rrUg_4core3pin3PinINtNtNtB6_5alloc4kbox3BoxNtNtNtB6_3pci3irq21IrqVectorRegistrationNtNtB1A_9allocator7KmallocEEEB6_() > rust/kernel.o: error: objtool: _RNvMNtCs65fqAZscXCv_6kernel6deviceNtB2_6Device10get_device() falls through to next function _RNvMNtCs65fqAZscXCv_6kernel6devresINtB2_6DevresNtNtB4_3i2c12RegistrationE19devres_node_releaseB4_() > rust/kernel.o: error: objtool: _RNvMNtCs65fqAZscXCv_6kernel6devresINtB2_6DevresNtNtB4_3i2c12RegistrationE19devres_node_releaseB4_() falls through to next function _RNvMNtCs65fqAZscXCv_6kernel6devresINtB2_6DevresNtNtB4_3i2c12RegistrationE21devres_node_free_nodeB4_() > > I understand this is probably due to a new function in Rust stdlib that > is no_return, so probably not caused by this patch even if this is > triggering it. I can't immediately reproduce this issue. I tried with linux-next (next-20260710), rustc 1.99.0-nightly (af3d95584 2026-07-09) and x86_64_defconfig with Rust enabled. What am I missing? Could you send me your config and the produced rust/kernel.o off-list? -- Thanks, Petr