From: Daniel Gomez <da.gomez@kernel.org>
To: Petr Pavlu <petr.pavlu@suse.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: Remove unused __INIT*_OR_MODULE macros
Date: Thu, 23 Oct 2025 00:55:29 +0200 [thread overview]
Message-ID: <e237939e-3c59-40b0-97e2-6c038f9e22a9@kernel.org> (raw)
In-Reply-To: <20250819121423.460156-1-petr.pavlu@suse.com>
On 19/08/2025 14.13, Petr Pavlu wrote:
> Remove the __INIT_OR_MODULE, __INITDATA_OR_MODULE and
> __INITRODATA_OR_MODULE macros. These were introduced in commit 8b5a10fc6fd0
> ("x86: properly annotate alternatives.c"). Only __INITRODATA_OR_MODULE was
> ever used, in arch/x86/kernel/alternative.c. In 2011, commit dc326fca2b64
> ("x86, cpu: Clean up and unify the NOP selection infrastructure") removed
> this usage.
>
> Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
> ---
> include/linux/module.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/linux/module.h b/include/linux/module.h
> index 3319a5269d28..e9e6eeb042aa 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -151,16 +151,10 @@ extern void cleanup_module(void);
> #define __init_or_module
> #define __initdata_or_module
> #define __initconst_or_module
> -#define __INIT_OR_MODULE .text
> -#define __INITDATA_OR_MODULE .data
> -#define __INITRODATA_OR_MODULE .section ".rodata","a",%progbits
> #else
> #define __init_or_module __init
> #define __initdata_or_module __initdata
> #define __initconst_or_module __initconst
> -#define __INIT_OR_MODULE __INIT
> -#define __INITDATA_OR_MODULE __INITDATA
> -#define __INITRODATA_OR_MODULE __INITRODATA
> #endif /*CONFIG_MODULES*/
>
> struct module_kobject *lookup_or_create_module_kobject(const char *name);
>
> base-commit: be48bcf004f9d0c9207ff21d0edb3b42f253829e
next prev parent reply other threads:[~2025-10-22 22:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 12:13 [PATCH] module: Remove unused __INIT*_OR_MODULE macros Petr Pavlu
2025-08-21 23:11 ` Sami Tolvanen
2025-10-22 22:55 ` Daniel Gomez [this message]
2025-10-23 2:43 ` Aaron Tomlin
2025-12-22 20:24 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e237939e-3c59-40b0-97e2-6c038f9e22a9@kernel.org \
--to=da.gomez@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox