From: Randy Dunlap <rdunlap@infradead.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Yury Norov <yury.norov@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ingo Molnar <mingo@kernel.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Petr Pavlu <petr.pavlu@suse.com>,
Daniel Gomez <da.gomez@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] kernel.h: move VERIFY_OCTAL_PERMISSIONS() to sysfs.h
Date: Mon, 1 Dec 2025 11:51:24 -0800 [thread overview]
Message-ID: <fd755bbf-50a8-46f7-bff1-61cc625118a9@infradead.org> (raw)
In-Reply-To: <aSydSI-h3KZiYBn6@smile.fi.intel.com>
On 11/30/25 11:38 AM, Andy Shevchenko wrote:
> On Sun, Nov 30, 2025 at 12:42:35PM -0500, Yury Norov wrote:
>> This series was tested by 0-day and LKP. 0-day runs allyesconfig,
>
> AFAICS in the below no configuration had been tested against allYESconfig.
> All of them are allNOconfig.
>
>> as far as I know. It only sends email in case of errors. LKP is OK, find the
>> report below.
>
>> All but XFS include it via linux/module.h -> linux/moduleparam.h path.
>> XFS has a linkage layer: xfs.h -> xfs_linux.h-> linux/module.h, so
>> it's pretty much the same.
>>
>> I think, module.h inclusion path is OK for this macro and definitely
>> better than kernel.h. Notice, none of them, except for vgpu_dbg,
>> include kernel.h directly.
>
> Ideally those (especially and in the first place headers) should follow IWYU
> principle and avoid indirect (non-guaranteed) inclusions.
Can you (or anyone) get IWYU (software) to work?
I tried it a few months ago but didn't have the correct magic
incantation for it.
(no specifics at the moment)
--
~Randy
next prev parent reply other threads:[~2025-12-01 19:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 19:52 [PATCH 0/3] Unload linux/kernel.h Yury Norov (NVIDIA)
2025-11-29 19:53 ` [PATCH 1/3] kernel.h: drop STACK_MAGIC macro Yury Norov (NVIDIA)
2025-11-29 20:32 ` Andy Shevchenko
2025-11-29 23:40 ` Randy Dunlap
2025-12-01 7:46 ` Jani Nikula
2025-12-02 20:58 ` Andi Shyti
2025-12-02 21:18 ` Yury Norov
2025-12-03 7:40 ` Jani Nikula
2025-12-01 9:38 ` Christophe Leroy (CS GROUP)
2025-12-02 2:50 ` Yury Norov
2025-12-02 7:37 ` Andy Shevchenko
2025-11-29 19:53 ` [PATCH 2/3] kernel.h: move VERIFY_OCTAL_PERMISSIONS() to sysfs.h Yury Norov (NVIDIA)
2025-11-29 20:24 ` Andy Shevchenko
2025-11-29 20:33 ` Andy Shevchenko
2025-11-29 20:35 ` Andy Shevchenko
2025-11-30 17:56 ` Yury Norov
2025-11-30 19:35 ` Andy Shevchenko
2025-11-30 6:19 ` Randy Dunlap
2025-11-30 17:42 ` Yury Norov
2025-11-30 19:38 ` Andy Shevchenko
2025-12-01 19:51 ` Randy Dunlap [this message]
2025-12-01 20:00 ` Andy Shevchenko
2025-11-30 18:27 ` Yury Norov
2025-11-30 19:42 ` Andy Shevchenko
2025-12-01 19:01 ` Petr Pavlu
2025-12-01 19:20 ` Andy Shevchenko
2025-11-29 19:53 ` [PATCH 3/3] tracing: move tracing declarations from kernel.h to a dedicated header Yury Norov (NVIDIA)
2025-11-29 20:30 ` Andy Shevchenko
2025-11-30 18:16 ` Yury Norov
2025-11-30 19:44 ` Andy Shevchenko
2025-11-30 20:36 ` Steven Rostedt
2025-11-30 23:09 ` david laight
2025-12-01 2:50 ` Andy Shevchenko
2025-12-01 10:16 ` david laight
2025-12-01 15:37 ` Andy Shevchenko
2025-11-30 20:34 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd755bbf-50a8-46f7-bff1-61cc625118a9@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=da.gomez@kernel.org \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rafael@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=rostedt@goodmis.org \
--cc=tursulin@ursulin.net \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).