From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E63FA328B75; Wed, 14 Oct 2026 02:36:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791945414; cv=none; b=J+c8siw2BknYXnv4zpV6F+366dsoyTXjxm761VuUjmxRs4XQL3o31W9aCNIvUaCiGhLfKwCiq9zgnnNuWJpUQbqHmpHJ3wOwVmaS0KUv4JYDsSUHImV2UJYm/qOA8Iro/E4Fas2S3YBXetOJluRhAlbahaNM/nBhMM67gfVg1Ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791945414; c=relaxed/simple; bh=BCvEKgBIwDJ1qyRihBWNXrrFNfkm7WgY14QuyKI4ctU=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=hbxeg6f3lkmB83Q6Qg5tnhZysuf7h8QWmxTeNXwog2U4NVCdNCouVDx5Owny6NWrmlJnt6Rqfx9w1SeSrpK8DeqkBLJSMzbPfb1bF9kHCBn2DOpn8f75jh5mkaYimzhg5ou6+I9SyE+jnBplaMvJYpzQD2KAwxJhKinMrL29AE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ge+uskZW; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ge+uskZW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCEB21F000FF; Wed, 14 Oct 2026 02:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791945413; bh=2FfgC2VWYJxMAMF2UyabFWui5TujrsyoVwpq5ybA3QQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ge+uskZW48jKdYTJzxeeYjVLIj7IQSapgt1gGLJQQBP+t+vYAGnd0GSWu38KGRS6W 6beqOnefcLSmcYKNXKmQQVuvDVhlpXCDA9VI+kZ1OAEWrOQUEpPtlGuGPiewBQMQR5 FtKL1uA9kMMn40uN/Stj/5J7rohvz9AqiGW6tzK3BhpPPc2CduaCj1cfwUc5QMdfln c7uWjdonvfW4YhUnZz3wLRC7xOG1TkoSn1rfTyoHj3JBuKskTqS/WSrN/VUH8CyCm7 Gn5nPtsoed3lm7WBegWrH1XgcsiflIDH/vn1vKuPtDIhPz8l8E4KQyJ29byvAkn1F9 J6JWr/N7suYOA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 10/40] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Reply-To: sashiko-reviews@lists.linux.dev To: "Jim Cromie" , "Jason Baron" , "Shuah Khan" , "Andrew Morton" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Arnd Bergmann" , "Luis Chamberlain" , "Petr Pavlu" , "Daniel Gomez" , "Sami Tolvanen" , "Aaron Tomlin" , "Jonathan Corbet" , "Greg Kroah-Hartman" , "Nathan Chancellor" , "Nicolas Schier" , "Shuah Khan" , "Randy Dunlap" , "Rafael J. Wysocki" , "Pavel Machek" , "Len Brown" , "Jonathan Corbet" , "Petr Mladek" , "Steven Rostedt" , "John Ogness" , "Sergey Senozhatsky" , =?utf-8?b?VGhvbWFzIFdlacOfc2NodWg=?= Cc: dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, "Louis Chauvet" In-Reply-To: <20261012-dd-cmap-part2-clean-v12-10-3c8cc5725def@gmail.com> References: <20261012-dd-cmap-part2-clean-v12-0-3c8cc5725def@gmail.com> <20261012-dd-cmap-part2-clean-v12-10-3c8cc5725def@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 14 Oct 2026 02:36:51 +0000 Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] dyndbg: documentation references future struct _ddebug_class_map -- commit 4edbf52dcd2e7bd06805f06e89c8d2ce8672c81b Author: Jim Cromie dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code This commit removes the unused DD_CLASS_TYPE_DISJOINT_NAMES and DD_CLASS_TYPE_LEVEL_NAMES classmap types and their corresponding code. It also renames enum class_map_type to enum ddebug_class_map_type. > diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h > index a10adac8e8f00..9607121c3072e 100644 > --- a/include/linux/dynamic_debug.h > +++ b/include/linux/dynamic_debug.h [ ... ] > @@ -119,8 +109,8 @@ struct ddebug_class_param { > =20 > /** > * DECLARE_DYNDBG_CLASSMAP - declare classnames known by a module > - * @_var: a struct ddebug_class_map, passed to module_param_cb > - * @_type: enum class_map_type, chooses bits/verbose, numeric/symbolic > + * @_var: a struct _ddebug_class_map, passed to module_param_cb [Severity: Low] This isn't a bug, but does this documentation reference a struct that doesn= 't exist yet? The comment here refers to struct _ddebug_class_map (with an underscore), but the macro DECLARE_DYNDBG_CLASSMAP currently instantiates struct ddebug_class_map. Is it intentional to document the future name before the actual struct rename occurs in a later patch? > + * @_maptype: enum ddebug_class_map_type, chooses bits/verbose > * @_base: offset of 1st class-name. splits .class_id space > * @classes: class-names used to control class'd prdbgs > */ --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261012-dd-cmap-pa= rt2-clean-v12-0-3c8cc5725def@gmail.com?part=3D10