From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793219121; b=bvKCgxLlfua0ISz7rFzMHPc1Nxw2KFhqUViaKUsTDp+Xep7elcp0pfwL0+7VTnybhErs +bGRVfdhs7HZYHj+VbU5yqUTSbxPgBjsbhzBWgV4dDdAR8vSEZJUWRUXFCEML3sVEKjIe 4W6/xURFBF8s6dkrHXFEDupSl4+/RT7Ay/lIrXPliSNCbaDzN5wl37fHAJHghwI+Y7hUt aUnWSMXPj/8z/OBf8grka9585MUSF5HpULHjSEfJ9J+KqaUI9jV4oUrqn0ddv0g6QXa8Z i8o9QJEawcBaiL35ZDUM18GStO+g3vf0L9X+jmq4kQyI/znpgvTHVrNYM70eOe/tTZQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793219121; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=Ch7sW4oN37R+cY4VFTmezwGOny97NPWGWNDoKEDXbyU=; b=BwQEUUC3f+EEI+BTZCf8N/R2QzIF5+GH2fft3DULo5xIAFNwfYzXmRm3f68E7WTWs3Tv e7qGG9VKdsOId2auEJnpRYvNAEriLttWD0CMIimI1ftiU9+Phx3BZBAXfIDo7oGlO8Iac veXM/nCz5wYmJvPd9qkb2o2L6EHzkktZgSkyJJcwuWo3CHfghEo/4tsPkJ+9GwedUnTLm r5P+JnJm9dOMrfF/m7eMuQEQz0f5FGNldjYpABcq/1W0FpQkm7DcGhHU9mViO3zr+FxBg wGZCTISPqxn5A51UfwcbiehDR6T8641eorISFpy4znPqyK2RZK7RcmtoT6wOs6C2lEA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lrsczSxL; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E371F606A31A; Wed, 28 Oct 2026 20:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lrsczSxL Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33EB91F01825; Wed, 28 Oct 2026 20:25:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793219120; bh=Ch7sW4oN37R+cY4VFTmezwGOny97NPWGWNDoKEDXbyU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lrsczSxLAiJLD3rgActjK/Xi+tSHOcRiRJaE0gBNTTemDGGVHQN75JovHOqeYwWdX jkp9VMpoxEXC0QtbEK55c2bw3TNizM7I3rL4jgeGWy/v2jl9Fmw0wWCSEGDdsTToaN zu64JetKiAWyg0fd02OHoVvlc/S0QPmi2+j71R8p8ZtosB3lRz/JYckWk44aY7NVOY VzBFHYSDd8smK7+NXyQPqzD7KARG6PG1kK8m+0J+2tmph5VoiYU9uMVYSYvSetFn8V Oy51hFz/A3tW7spLT989SNYlvQRRQRvZfA2qZZDuxtH4JLkXHQZepXZZkmKlUZBXb0 a66f1fPgaZimQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v13 27/39] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API Reply-To: sashiko-reviews@lists.linux.dev To: "Jim Cromie" , "Jason Baron" , "Shuah Khan" , "Andrew Morton" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Arnd Bergmann" , "Luis Chamberlain" , "Petr Pavlu" , "Daniel Gomez" , "Sami Tolvanen" , "Aaron Tomlin" , "Jonathan Corbet" , "Greg Kroah-Hartman" , "Nathan Chancellor" , "Nicolas Schier" , "Shuah Khan" , "Randy Dunlap" , "Rafael J. Wysocki" , "Pavel Machek" , "Len Brown" , "Jonathan Corbet" , "Petr Mladek" , "Steven Rostedt" , "John Ogness" , "Sergey Senozhatsky" , =?utf-8?b?VGhvbWFzIFdlacOfc2NodWg=?= , "Jason A. Donenfeld" Cc: dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, "Jason Baron" , "Louis Chauvet" In-Reply-To: <20261027-dd-cmap-part2-clean-v13-27-9267923be612@gmail.com> References: <20261027-dd-cmap-part2-clean-v13-0-9267923be612@gmail.com> <20261027-dd-cmap-part2-clean-v13-27-9267923be612@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 28 Oct 2026 20:25:17 +0000 X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] dyndbg: wrong function name in param_set_dyndbg_module_classes() ke= rnel-doc -- commit 43feafd46a08a5ee8ddfaa269bc39a26e9e8a8a4 Author: Jim Cromie dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API This commit moves the DYNAMIC_DEBUG_CLASSMAP_PARAM macro from test_dynamic_debug.c into dynamic_debug.h, splits it into DYNAMIC_DEBUG_CLASSMAP_PARAM and DYNAMIC_DEBUG_CLASSMAP_PARAM_REF, and adds fallback definitions for !CONFIG_DYNAMIC_DEBUG. > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c > index 1983f672dcfb2..8d9eb7dc09995 100644 > --- a/lib/dynamic_debug.c > +++ b/lib/dynamic_debug.c > @@ -698,9 +698,42 @@ static int ddebug_apply_class_bitmap(const struct dd= ebug_class_param *dcp, [ ... ] > +/** > + * param_set_dyndbg_classes - class FOO >control > + * @instr: string echo>d to sysfs, input depends on map_type > + * @kp: kp->arg has state: bits/lvl, map, map_type > + * @mod_name: module name or null for all modules with the classes > + * > + * Enable/disable prdbgs by their class, as given in the arguments to > + * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative > + * levels by bitpos. > + * > + * Returns: 0 or <0 if error. > */ > static int param_set_dyndbg_module_classes(const char *instr, > const struct kernel_param *kp, > const char *mod_name) [Severity: Low] Should the kernel-doc identifier here be param_set_dyndbg_module_classes instead of param_set_dyndbg_classes? With the comment converted to a /** kernel-doc block in lib/dynamic_debug.c, building with W=3D1 causes scripts/kernel-doc (via dump_function() in tools/lib/python/kdoc/kdoc_parser.py) to warn that it was expecting a prototype for param_set_dyndbg_classes() when encountering the prototype for param_set_dyndbg_module_classes(). --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261027-dd-cmap-pa= rt2-clean-v13-0-9267923be612@gmail.com?part=3D27