Re: [PATCH v11 4/4] kallsyms: add KUnit tests for lineinfo feature

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] kallsyms: skip_without_module_lineinfo() misses parisc32 .text.*
  sections
--

commit 0acb15a1e169631dad96f85b0c77c16a41dabc41
Author: Sasha Levin <sashal@kernel.org>

kallsyms: add KUnit tests for lineinfo feature

This commit adds a KUnit test module (CONFIG_LINEINFO_KUNIT_TEST) to
verify that the kallsyms lineinfo feature produces source file:line
annotations in stack traces, and exports sprint_backtrace() and
sprint_backtrace_build_id() for KUnit tests.

> diff --git a/lib/tests/lineinfo_kunit.c b/lib/tests/lineinfo_kunit.c
> new file mode 100644
> index 0000000000000..fc1b97ffb5251
> --- /dev/null
> +++ b/lib/tests/lineinfo_kunit.c
> @@ -0,0 +1,1087 @@

[ ... ]

> +/*
> + * When the test is built as a module but CONFIG_KALLSYMS_LINEINFO_MODULES
> + * is disabled, the test module's own functions have no lineinfo tables, so
> + * every test that expects annotations on local targets must skip rather
> + * than fail.
> + */
> +static void skip_without_module_lineinfo(struct kunit *test)
> +{
> +	if (IS_MODULE(CONFIG_LINEINFO_KUNIT_TEST) &&
> +	    !IS_ENABLED(CONFIG_KALLSYMS_LINEINFO_MODULES))
> +		kunit_skip(test,
> +			   "KALLSYMS_LINEINFO_MODULES disabled; test module has no lineinfo");
> +}

[Severity: Low]
Will all tests that inspect local module functions fail when
CONFIG_LINEINFO_KUNIT_TEST=m is built on 32-bit parisc?

On 32-bit parisc, CONFIG_ARCH_WANTS_MODULES_TEXT_SECTIONS is selected and
KBUILD_CFLAGS_MODULE enables -ffunction-sections, which keeps module
functions in per-function .text.* sections instead of merging them into
.text.  scripts/gen_lineinfo.c places those .text.* sections into
extra_sections[] and drops their DWARF line entries, so local test targets
have no lineinfo even when CONFIG_KALLSYMS_LINEINFO_MODULES is enabled.

Passing -fno-function-sections for the test objects in lib/tests/Makefile
(or checking IS_ENABLED(CONFIG_ARCH_WANTS_MODULES_TEXT_SECTIONS) in
skip_without_module_lineinfo()) would avoid these failures.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106132432.248387-1-sashal@kernel.org?part=4