From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Yauheni Kaliuta To: Lucas De Marchi Cc: linux-modules , Mian Yousaf Kaukab , bjorn.andersson@linaro.org Subject: Re: [PATCH RFC 3/3] depmod: handle nested loops References: <1478683053.4155.8.camel@suse.com> <1478864601-3259-1-git-send-email-yauheni.kaliuta@redhat.com> <1478864601-3259-4-git-send-email-yauheni.kaliuta@redhat.com> Date: Mon, 20 Feb 2017 16:16:37 +0200 In-Reply-To: (Lucas De Marchi's message of "Mon, 13 Feb 2017 00:30:53 -0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-ID: Hi, Lucas! >>>>> On Mon, 13 Feb 2017 00:30:53 -0800, Lucas De Marchi wrote: > On Fri, Nov 11, 2016 at 3:43 AM, Yauheni Kaliuta > wrote: >> This is a rework of depmod report cycles logic to make it >> tolerant to more complex loops. >> >> The patch tries to remember own path for vertexes which makes it >> possible to handle configurations with common edges and >> non-cyclic modules. >> >> It assumes that the previous dependency calculations can not give >> as input something like >> >> mod_a -> mod_b -> , but >> >> -> mod_a -> mod_b should be fine. >> >> Signed-off-by: Yauheni Kaliuta >> --- >> tools/depmod.c | 287 ++++++++++++++++++++++++++++++++++++++++----------------- >> 1 file changed, 204 insertions(+), 83 deletions(-) [...] >> -- > Rest looks good. I'm sending v2 which addresses your comments. One question: there is a bunch of memory leaks in -ENOMEM error path (what doesn't sound as a real problem for depmod tool since it should exit anyway after that). Would you like me to fix it as well? -- WBR, Yauheni Kaliuta