From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Subject: Re: [PATCH v4 01/17] x86/mpx: Do not use SIB index if index points
 to R/ESP
Date: Thu, 23 Feb 2017 14:17:12 -0800
Message-ID: <1487888232.115017.4.camel@ranerica-desktop>
References: <20170223063706.71554-1-ricardo.neri-calderon@linux.intel.com>
         <20170223063706.71554-2-ricardo.neri-calderon@linux.intel.com>
         <20170223072432.GX6515@twins.programming.kicks-ass.net>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <linux-msdos-owner@vger.kernel.org>
In-Reply-To: <20170223072432.GX6515@twins.programming.kicks-ass.net>
Sender: linux-msdos-owner@vger.kernel.org
List-ID: <linux-msdos.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>, Andrew Morton <akpm@linux-foundation.org>, Brian Gerst <brgerst@gmail.com>, Chris Metcalf <cmetcalf@mellanox.com>, Dave Hansen <dave.hansen@linux.intel.com>, Paolo Bonzini <pbonzini@redhat.com>, Liang Z Li <liang.z.li@intel.com>, Masami Hiramatsu <mhiramat@kernel.org>, Huang Rui <ray.huang@amd.com>, Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>, "Michael S. Tsirkin" <mst@redhat.com>, Paul Gortmaker <paul.gortmaker@windriver.com>, Vlastimil Babka <vbabka@suse.cz>, Chen Yucong <slaoub@gmail.com>, Alexandre Julliard <julliard@winehq.org>, Stas Sergeev <sts>

On Thu, 2017-02-23 at 08:24 +0100, Peter Zijlstra wrote:
> On Wed, Feb 22, 2017 at 10:36:50PM -0800, Ricardo Neri wrote:
> > +			/*
> > +			 * A negative offset generally means a error, except
> > +			 * -EDOM, which means that the contents of the register
> > +			 * should not be used as index.
> > +			 */
> >  			if (indx_offset < 0)
> > -				goto out_err;
> > +				if (indx_offset == -EDOM)
> > +					indx = 0;
> > +				else
> > +					goto out_err;
> > +			else
> > +				indx = regs_get_register(regs, indx_offset);
> 
> Kernel coding style requires more brackets than are strictly required by
> C, any block longer than 1 line needs then. Also, if one leg of a
> conditional needs them, then they should be on both legs.
> 
> Your code has many such instances, please change them all.

Will do. Sorry for the noise. These instances escaped the checkpatch
script.

Thanks and BR,
Ricardo