public inbox for linux-msdos@vger.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Brian Gerst <brgerst@gmail.com>,
	Chris Metcalf <cmetcalf@mellanox.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Liang Z Li <liang.z.li@intel.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Huang Rui <ray.huang@amd.com>, Jiri Slaby <jslaby@suse.cz>,
	Jonathan Corbet <corbet@lwn.net>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Vlastimil Babka <vbabka@suse.cz>, Chen Yucong <slaoub@gmail.com>,
	A
Subject: Re: [PATCH v4 03/17] x86/mpx, x86/insn: Relocate insn util functions to a new insn-kernel
Date: Thu, 23 Feb 2017 14:18:04 -0800	[thread overview]
Message-ID: <1487888284.115017.5.camel@ranerica-desktop> (raw)
In-Reply-To: <201702231831.ALp3TpDE%fengguang.wu@intel.com>

On Thu, 2017-02-23 at 18:54 +0800, kbuild test robot wrote:
> >> arch/x86/lib/insn-eval.c:106:21: error: static declaration of
> 'insn_get_addr_ref' follows non-static declaration
>     static void __user *insn_get_addr_ref(struct insn *insn, struct
> pt_regs *regs)
>                         ^~~~~~~~~~~~~~~~~
>    In file included from arch/x86/lib/insn-eval.c:10:0:
>    arch/x86/include/asm/insn-eval.h:14:14: note: previous declaration
> of 'insn_get_addr_ref' was here
>     void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs
> *regs);
>                  ^~~~~~~~~~~~~~~~~
>    arch/x86/lib/insn-eval.c:106:21: warning: 'insn_get_addr_ref'
> defined but not used [-Wunused-function]
>     static void __user *insn_get_addr_ref(struct insn *insn, struct
> pt_regs *regs)
>                         ^~~~~~~~~~~~~~~~~
> 
> vim +/insn_get_addr_ref +106 arch/x86/lib/insn-eval.c

Uh! This escaped my tests after many rebases. I will correct it.

Thanks and BR,
Ricardo


  reply	other threads:[~2017-02-23 22:18 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23  6:36 [PATCH v4 00/17] x86: Enable User-Mode Instruction Prevention Ricardo Neri
2017-02-23  6:36 ` [PATCH v4 01/17] x86/mpx: Do not use SIB index if index points to R/ESP Ricardo Neri
2017-02-23  7:24   ` Peter Zijlstra
2017-02-23  9:50     ` Paul Crawford
2017-02-23 12:47       ` Coding style vs legibility [was Re: [PATCH v4 01/17] x86/mpx: Do not use SIB index if index points to R/ESP] Mouse
2017-02-23 22:17     ` [PATCH v4 01/17] x86/mpx: Do not use SIB index if index points to R/ESP Ricardo Neri
2017-02-24  2:33       ` Joe Perches
2017-02-24  2:41         ` Ricardo Neri
2017-02-24 14:47         ` Nathan Howard
2017-02-24 19:07           ` Ricardo Neri
2017-02-24 15:00         ` Adan Hawthorn
2017-02-23  6:36 ` [PATCH v4 02/17] x86/mpx: Do not use R/EBP as base in the SIB byte with Mod = 0 Ricardo Neri
2017-02-23  6:36 ` [PATCH v4 03/17] x86/mpx, x86/insn: Relocate insn util functions to a new insn-kernel Ricardo Neri
2017-02-23 10:54   ` kbuild test robot
2017-02-23 22:18     ` Ricardo Neri [this message]
2017-02-23  6:36 ` [PATCH v4 04/17] x86/insn-eval: Add utility functions to get register offsets Ricardo Neri
2017-02-23  6:36 ` [PATCH v4 05/17] x86/insn-eval: Add utility function to get segment selector Ricardo Neri
2017-02-23  6:36 ` [PATCH v4 06/17] x86/insn-eval: Add utility function to get segment descriptor Ricardo Neri
2017-02-23  6:36 ` [PATCH v4 07/17] x86/insn-eval: Add utility function to get segment descriptor base address Ricardo Neri
2017-02-23  6:36 ` [PATCH v4 08/17] x86/insn-eval: Add functions to get default operand and address sizes Ricardo Neri
2017-02-23  6:36 ` [PATCH v4 09/17] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero Ricardo Neri
2017-02-23  6:36 ` [PATCH v4 10/17] insn/eval: Incorporate segment base in address computation Ricardo Neri
2017-02-23  6:37 ` [PATCH v4 11/17] x86/insn-eval: Add support to resolve 16-bit addressing encodings Ricardo Neri
2017-02-23  6:37 ` [PATCH v4 12/17] x86/cpufeature: Add User-Mode Instruction Prevention definitions Ricardo Neri
2017-02-23  6:37 ` [PATCH v4 13/17] x86: Add emulation code for UMIP instructions Ricardo Neri
2017-02-23  6:37 ` [PATCH v4 14/17] x86/umip: Force a page fault when unable to copy emulated result to user Ricardo Neri
2017-02-23  6:37 ` [PATCH v4 15/17] x86/traps: Fixup general protection faults caused by UMIP Ricardo Neri
2017-02-23  9:27   ` Peter Zijlstra
2017-02-23 22:15     ` Ricardo Neri
2017-02-24 19:11       ` Andy Lutomirski
2017-02-24 19:36         ` Ricardo Neri
2017-02-24 19:45           ` H. Peter Anvin
2017-02-23  6:37 ` [PATCH v4 16/17] x86: Enable User-Mode Instruction Prevention Ricardo Neri
2017-02-23  6:37 ` [PATCH v4 17/17] selftests/x86: Add tests for " Ricardo Neri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487888284.115017.5.camel@ranerica-desktop \
    --to=ricardo.neri-calderon@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=brgerst@gmail.com \
    --cc=cmetcalf@mellanox.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jslaby@suse.cz \
    --cc=kbuild-all@01.org \
    --cc=liang.z.li@intel.com \
    --cc=lkp@intel.com \
    --cc=luto@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mst@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ray.huang@amd.com \
    --cc=slaoub@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox