From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Subject: Re: [v5 17/20] x86/umip: Force a page fault when unable to copy
 emulated result to user
Date: Mon, 06 Mar 2017 16:26:01 -0800
Message-ID: <1488846361.131264.0.camel@ranerica-desktop>
References: <20170303214132.77244-1-ricardo.neri-calderon@linux.intel.com>
         <20170303214132.77244-18-ricardo.neri-calderon@linux.intel.com>
         <CALCETrW=QOnXUFoDS0rFN0bzN4nB8a8-EOqM_YPhm1EJ7Q07pA@mail.gmail.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CALCETrW=QOnXUFoDS0rFN0bzN4nB8a8-EOqM_YPhm1EJ7Q07pA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-msdos.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Andy Lutomirski <luto@amacapital.net>
Cc: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>, Peter Zijlstra <peterz@infradead.org>, Andrew Morton <akpm@linux-foundation.org>, Brian Gerst <brgerst@gmail.com>, Chris Metcalf <cmetcalf@mellanox.com>, Dave Hansen <dave.hansen@linux.intel.com>, Paolo Bonzini <pbonzini@redhat.com>, Liang Z Li <liang.z.li@intel.com>, Masami Hiramatsu <mhiramat@kernel.org>, Huang Rui <ray.huang@amd.com>, Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>, "Michael S. Tsirkin" <mst@redhat.com>, Paul Gortmaker <paul.gortmaker@windriver.com>, Vlastimil Babka <vbabka@suse.cz>, Chen Yucong <slaoub@gmail.com>, Alexandre Julliard <>

On Sun, 2017-03-05 at 08:18 -0800, Andy Lutomirski wrote:
> > + */
> > +static void __force_sig_info_umip_fault(void __user *address,
> > +                                       struct pt_regs *regs)
> > +{
> > +       siginfo_t info;
> > +       struct task_struct *tsk = current;
> > +
> > +       if (show_unhandled_signals && unhandled_signal(tsk,
> SIGSEGV)) {
> > +               printk_ratelimited("%s[%d] umip emulation segfault
> ip:%lx sp:%lx error:%lx in %lx\n",
> > +                                  tsk->comm, task_pid_nr(tsk),
> regs->ip,
> > +                                  regs->sp, UMIP_PF_USER |
> UMIP_PF_WRITE,
> > +                                  regs->ip);
> > +       }
> > +
> > +       tsk->thread.cr2         = (unsigned long)address;
> > +       tsk->thread.error_code  = UMIP_PF_USER | UMIP_PF_WRITE;
> 
> Please just move enum x86_pf_error_code into a header and rename the
> fields X86_PF_USER, etc rather than duplicating it.

Thanks again for your feedback! I will do this.