Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero

Ricardo Neri
2017-05-12T01:57:50Z

On Sun, 2017-05-07 at 19:20 +0200, Borislav Petkov wrote:
> On Wed, Apr 26, 2017 at 06:29:59PM -0700, Ricardo Neri wrote:
> > > if (X86_MODRM_MOD(insn->modrm.value) == 0 &&
> > > X86_MODRM_RM(insn->modrm.value) == 5)
> > >
> > > looks more understandable to me.
> >
> > Should I go with !(X86_MODRM_MOD(insn->modrm.value)) as you suggested in
> > other patches?
>
> Ah, yes pls.
>
I did this in v7[1].

Thanks and BR,
Ricardo

[1]. https://lkml.org/lkml/2017/5/5/399