Re: non-privileged raw keyboard

["Witold Filipczyk" <juandon@poczta.onet.pl>]

On Sun, Apr 07, 2002 at 06:52:13PM +0100, Bart Oldeman wrote:
> On Sun, 7 Apr 2002, Witold Filipczyk wrote:
> 
> > Second part - video doesn't work for me.
> > /dev/mem can't write errno 13 (something like this)
> > (I use SVGATextMode).
> > My proposal of this patch is in attachment (keyboard only)
> 
> This was a bug, which was only exposed by my changes.
> It depended on the setting of $_console: $_console is a protected
> setting. But there is/was confusion between config.console and
> config.console_video: $_console sets config.console_video and not
> config.console. config.console is set if certain ioctls find out that we
> are running on the console. I don't completely understand this but the
> following should fix your problem as well:
> 
> --- src/base/init/config.c.old	Sun Apr  7 18:42:14 2002
> +++ src/base/init/config.c	Sun Apr  7 18:43:05 2002
> @@ -741,7 +741,7 @@
>  	config.emuretrace = 0;	/* already emulated */
>      }
>      else {
> -	if (!can_do_root_stuff && config.console) {
> +	if (!can_do_root_stuff && config.console_video) {
>  	    /* force use of Slang-terminal on console too */
>  	    config.console = config.console_video = config.vga = config.graphics = 0;
>  	    config.cardtype = 0;
> 
> and I prefer this (+ my complete earlier patch) to your solution;)
> 
> IMHO the member config.console should be eliminated here to avoid
> further confusion but let's do that later.
> Please let me know if this helps you too.

Now, works fine.
WF