Re: dosemu 1.1.5.7 (was Re: dosemu 1.1.5.6)

Bart Oldeman
2003-08-23T22:17:14Z

On Sat, 23 Aug 2003, Ryan Underwood wrote:

> On Sat, Aug 23, 2003 at 08:47:33PM +0100, Bart Oldeman wrote:
> > On Sat, 23 Aug 2003, Ryan Underwood wrote:
> >
> > > The problem is that when debian/rules install target calls the install
> > > target for DOSEMU, MAKELEVEL is 1, not zero, so abs_top_builddir is not
> > > set, and Makefile.main's install target tries to rm -rf /tmp (!).
> >
> > Looks like Debian fixed that:
> > http://cvs.debian.org/debian-installer/build/Makefile
> > http://cvs.debian.org/debian-installer/build/Makefile.diff?r1=1.154&r2=1.155
>
> Well, that particular patch looks like it is for the debian-installer
> package which is not related to DOSEMU. However, I can use the same
> trick in my build script. I'm mainly curious why this only started
> happening in 1.1.5.7 -- I built 1.1.5.6 and previous with no
> modifications or extra pain needed.

well the trick avoids using $(shell ... pwd) in Makefiles for each
recursive invocation of "make". $(shell) is fairly expensive; by reducing
the number of it to exactly one (instead of ~100 in 1.1.5.6) it was
possible to reduce the time to "make" a (nearly) built tree
significantly, on one PC by about 10 seconds from 15 to less than 5; and
Clarence Dang has seen even greater differences.

For a user who compiles her/himself this doesn't matter that much but for
a developer who often makes a small change and then recompiles it saves a
lot of waiting.

Bart