From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mouse Subject: Coding style vs legibility [was Re: [PATCH v4 01/17] x86/mpx: Do not use SIB index if index points to R/ESP] Date: Thu, 23 Feb 2017 07:47:50 -0500 (EST) Message-ID: <201702231247.HAA12538@Stone.Rodents-Montreal.ORG> References: <20170223063706.71554-1-ricardo.neri-calderon@linux.intel.com> <20170223063706.71554-2-ricardo.neri-calderon@linux.intel.com> <20170223072432.GX6515@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7BIT Return-path: In-Reply-To: Sender: linux-msdos-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: linux-msdos@vger.kernel.org > Certainly if you have code with an odd mix of styles it is much > harder to read, and ultimately source code is for *humans* to > understand. So enforcing a consistent style, even if it is not your > own style, makes it much easier to follow! It can. It doesn't always. I've yet to see a coding style rule that can't profitably be broken in at least a few cases ("profitably" here meaning, the breaking actually improves rather than impairs readability). Truly did Emerson write that "[a] foolish consistency is the hobgoblin of little minds". Readability is a fundamentally subjective thing, after all, and thus brings all of the human layer's messy inconsistency with it. /~\ The ASCII Mouse \ / Ribbon Campaign X Against HTML mouse@rodents-montreal.org / \ Email! 7D C8 61 52 5D E7 2D 39 4E F1 31 3E E8 B3 27 4B