From mboxrd@z Thu Jan  1 00:00:00 1970
From: "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v4 15/17] x86/traps: Fixup general protection faults caused by UMIP
Date: Fri, 24 Feb 2017 11:45:05 -0800
Message-ID: <201702241945.v1OJjDKZ011535@mail.zytor.com>
References: <20170223063706.71554-1-ricardo.neri-calderon@linux.intel.com> <20170223063706.71554-16-ricardo.neri-calderon@linux.intel.com> <20170223092724.GZ6515@twins.programming.kicks-ass.net> <1487888144.115017.3.camel@ranerica-desktop> <CALCETrX-b1Pjz=bFfj+YFk=Fgy5FKTpAYig__zF=GTn4VXNf4w@mail.gmail.com> <1487964979.115017.11.camel@ranerica-desktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Return-path: <linux-msdos-owner@vger.kernel.org>
In-Reply-To: <1487964979.115017.11.camel@ranerica-desktop>
Sender: linux-msdos-owner@vger.kernel.org
List-ID: <linux-msdos.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>, Andy Lutomirski <luto@amacapital.net>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>, Andrew Morton <akpm@linux-foundation.org>, Brian Gerst <brgerst@gmail.com>, Chris Metcalf <cmetcalf@mellanox.com>, Dave Hansen <dave.hansen@linux.intel.com>, Paolo Bonzini <pbonzini@redhat.com>, Liang Z Li <liang.z.li@intel.com>, Masami Hiramatsu <mhiramat@kernel.org>, Huang Rui <ray.huang@amd.com>, Jiri Slaby <jslaby@suse.cz>, Jonathan Corbet <corbet@lwn.net>, "Michael S. Tsirkin" <mst@redhat.com>, Paul Gortmaker <paul.gortmaker@windriver.com>, Vlastimil Babka <vbabka@suse.cz>, Chen Yucong <slaoub@gmail.com>, Alexandre Julliard <julliard@winehq.org>, Stas

Luck <tony.luck@intel.com>
From: hpa@zytor.com
Message-ID: <C4474E45-EAE0-45D3-8DB1-78AA1C2548A8@zytor.com>

On February 24, 2017 11:36:19 AM PST, Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:
>On Fri, 2017-02-24 at 11:11 -0800, Andy Lutomirski wrote:
>> > In a previous version Andy Lutomirsky suggested that
>> >         if (user_mode(regs) && (fixup_umip_exception(regs) == 0))
>> >
>> > was easier to read :). Although at the time fixup_umip_exception
>> > returned a numeric value. Now it only returns true/false for
>> > successful/failed emulation. If with true/false not comparing to
>> true
>> > makes it easier to read, I will make the change.
>> 
>> I think == true is silly :)
>
>Then I'll make the change.
>
>Thanks and BR,
>Ricardo

It's worse than silly, it is potentially toxic.

true is a macro which it's defined as 1.  Thus

     foo == true

... doesn't actually mean what people *think* it does, which is roughly the same thing as

    !!foo

However, if foo is not a boolean, this is *very* different; consider if foo is 2.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.