Re: [PATCH v7 13/26] x86/insn-eval: Add function to get default params of code segment

Borislav Petkov
2017-06-19T17:11:52Z

On Thu, Jun 15, 2017 at 12:24:35PM -0700, Ricardo Neri wrote:
> OK. This makes sense. Perhaps I can use a couple of #define's to set and
> get the the address and operand sizes in a single u8. This would make
> the code more readable.

Sure but don't get too tangled in defines if it is going to be used
in one place only. Sometimes a clear comment and the naked bitwise
operations are already clear enough.

> Alternatively, I can do desc->type & BIT(3) to avoid using desc-b, which
> is less elegant.

Sure.

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--