Re: [PATCH][1.1.3.2] keystroke - option P not working (unicode keyboard)

Re: [PATCH][1.1.3.2] keystroke - option P not working (unicode keyboard)

[Stas Sergeev]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hello.

Per Jessen wrote:
> attached is a patch for the \P on the keystroke
> config option not working with the unicode keyboard 
It's a very late night here
and I have looked neither in
the code nor in the problem,
but somehow it happened that
I don't like your patch (sorry).
I'll have a look tomorrow but
for now please check if the
attached patch fixes your
problem.

[-- Attachment #2: strtol.diff --]
[-- Type: text/plain, Size: 312 bytes --]

--- src/plugin/translate/unicode_utils.c	Sun Jun 16 18:30:20 2002
+++ src/plugin/translate/unicode_utils.c	Sun Aug  4 05:27:50 2002
@@ -97,7 +97,7 @@
 	sign = 1;
 	result = 0;
 
-	if ((base < 2) || (base > 36)) {
+	if (base && ((base < 2) || (base > 36))) {
 		if (endptr) {
 			*endptr = (t_unicode *)ptr;
 		}

Re: [PATCH][1.1.3.2] keystroke - option P not working (unicode keyboard)

[Stas Sergeev]

Hello.

Per Jessen wrote:
> let me know - it works here.
Good :)

> If you don't like the added
> debug output, well ... :-)
I don't like it because you
have a single string duplicating
many times. Just putting it
right before the switch() would
be OKey I think. Also for 'A'
you are adding that string after
"ch=*(in++);" and for M - before,
which seems buggy.
Decorating the bugfix with
a debug changes is not a problem
in general but it should be more
accurate.
But anyway this doesn't as matter
as the change you propose for
unicode_utils.c, which, unless
you can justify it of course,
is not recommended to apply at
all.