From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stas Sergeev Subject: Re: [PATCH][1.1.3.2] keystroke - option P not working (unicode keyboard) Date: Sun, 04 Aug 2002 15:59:50 +0400 Sender: linux-msdos-owner@vger.kernel.org Message-ID: <3D4D1736.6020501@yahoo.com> Reply-To: stas.orel@mailcity.com Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: List-Id: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: linux-msdos@vger.kernel.org Hello. Per Jessen wrote: > let me know - it works here. Good :) > If you don't like the added > debug output, well ... :-) I don't like it because you have a single string duplicating many times. Just putting it right before the switch() would be OKey I think. Also for 'A' you are adding that string after "ch=*(in++);" and for M - before, which seems buggy. Decorating the bugfix with a debug changes is not a problem in general but it should be more accurate. But anyway this doesn't as matter as the change you propose for unicode_utils.c, which, unless you can justify it of course, is not recommended to apply at all.