Re: vmodem patch

[Stas Sergeev <stssppnn@yahoo.com>]

Hello.

aric2746 wrote:
> This is a patch for vmodem, fixes something about child processes,
Dosemu doesn't spawn a child processes
(unless it is the 1.1.4+, but that's a
different story).

> Without
> the patch if a users hanged up while playing a door game on a bbs, the
> process would still be loaded, with this patch the problem is solved.
You are hacking leavedos(). When this is
executed, nothing will be loaded after.

I guess, what you are going to achieve,
is to pass the interrupt to the program,
so that it can react to a hangup and do
some cleanups before dosemu is terminated.

Hacking a leavedos() for it doesn't look
good. You can implement a separate handler
for SIGHUP instead.

10sec timeout also doesn't look good.
You can use an "interrupt acknowledge"
as an indicator. This will be an MSR
read in your case.

It is better to use a proper DCD mask
instead of 255, and to reset only the
ports that have a "virtual" flag (but
as dosemu is going to terminate at that
point, this is not very important:)

> I not
> a coder, so I hope someone can upgrade this patch to the lastest dosemu
> build along with vmodem.
Well, you have to describe the problem
in more details. I hope I guessed it
from the patch correctly, but guessing
the problems is not the best way to get
them fixed.