From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stas Sergeev Subject: Re: [v6 PATCH 00/21] x86: Enable User-Mode Instruction Prevention Date: Fri, 10 Mar 2017 01:10:03 +0300 Message-ID: References: <20170308003254.27833-1-ricardo.neri-calderon@linux.intel.com> <79ba0fff-4c01-2bfa-06cb-5cfc98dd710c@list.ru> <997ba581-ecfa-b773-a48e-85b92a439836@list.ru> <1489022122.131264.33.camel@ranerica-desktop> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=list.ru; s=mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject; bh=XjpmvdG6UoVWLKbOu8fEjqsV5j1ZXWESzuQ4U5zhwrQ=; b=DupiIa/OBuFOXbYjyQs3ZL/13eQsGO3zu81j8U2zzFFVTYvodKqfCI7gXYWHnAgFllLZXKnetGK0H03SCTvO7YiLMkxCT21PhawDjr7SpCq5py0v20S9QuIRtopAxeiAoJJ+nEjaDa7fzNEVbo8FGYwyyttCAIX5WZ8KXFXQPus=; In-Reply-To: <1489022122.131264.33.camel@ranerica-desktop> Sender: linux-msdos-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="utf-8"; format="flowed" To: Ricardo Neri , Andy Lutomirski Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andy Lutomirski , Borislav Petkov , Peter Zijlstra , Andrew Morton , Brian Gerst , Chris Metcalf , Dave Hansen , Paolo Bonzini , Liang Z Li , Masami Hiramatsu , Huang Rui , Jiri Slaby , Jonathan Corbet , "Michael S. Tsirkin" , Paul Gortmaker , Vlastimil Babka , Chen Yucong , Alexandre Julliard <> 09.03.2017 04:15, Ricardo Neri пишет: > On Wed, 2017-03-08 at 08:46 -0800, Andy Lutomirski wrote: >> On Wed, Mar 8, 2017 at 8:29 AM, Stas Sergeev wrote: >>> 08.03.2017 19:06, Andy Lutomirski пишет: >>>> On Wed, Mar 8, 2017 at 6:08 AM, Stas Sergeev wrote: >>>>> 08.03.2017 03:32, Ricardo Neri пишет: >>>>>> These are the instructions covered by UMIP: >>>>>> * SGDT - Store Global Descriptor Table >>>>>> * SIDT - Store Interrupt Descriptor Table >>>>>> * SLDT - Store Local Descriptor Table >>>>>> * SMSW - Store Machine Status Word >>>>>> * STR - Store Task Register >>>>>> >>>>>> This patchset initially treated tasks running in virtual-8086 >> mode as a >>>>>> special case. However, I received clarification that DOSEMU[8] >> does not >>>>>> support applications that use these instructions. >>>> Can you remind me what was special about it? It looks like you >> still >>>> emulate them in v8086 mode. >>> Indeed, sorry, I meant prot mode here. :) >>> So I wonder what was cited to be special about v86. > Initially my patches disabled UMIP on virtual-8086 instructions, without > regards of protected mode (i.e., UMIP was always enabled). I didn't have > emulation at the time. Then, I added emulation code that now covers > protected and virtual-8086 modes. I guess it is not special anymore. But isn't SLDT&friends just throw UD in v86? How does UMIP affect this? How does your patch affect this?