* MTD partitioning rewrite finished
@ 2001-11-05 16:22 Jörn Engel
2001-11-06 12:39 ` Jörn Engel
0 siblings, 1 reply; 6+ messages in thread
From: Jörn Engel @ 2001-11-05 16:22 UTC (permalink / raw)
To: linux-mtd; +Cc: Eric
Hi!
The code has matured enough on my machine that normal people might try
it, too. You can download a patch against 2.4.13 now, I don't have to
scare away normal users anymore. :)
I also truncated the patch into several smaller ones as the mapping
stuff and the partition parser are optional. 40k is still plenty.
Here are the links for the web page and the direct download:
http://wh.fh-wedel.de/~joern/software/kernel/
http://wh.fh-wedel.de/~joern/software/kernel/mtd_je.patch.2.4.13
Jörn
PS: Eric, I cc'd you as you said you had a non-academic use for this
stuff. It would be nice to get some feedback. "works" is enough,
"breaks at this point" is better, "this code looks odd" would really
help me to improve the code and my style.
--
Beware of bugs in the above code; I have only proved it correct,
but not tried it.
-- Donald Knuth
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: MTD partitioning rewrite finished
2001-11-05 16:22 MTD partitioning rewrite finished Jörn Engel
@ 2001-11-06 12:39 ` Jörn Engel
2001-11-06 13:11 ` Bug in mtdblock_ro Simon Barber
0 siblings, 1 reply; 6+ messages in thread
From: Jörn Engel @ 2001-11-06 12:39 UTC (permalink / raw)
To: linux-mtd
Hi!
Kernel 2.4.14 is out, I adjusted my patches a bit and I found and
corrected some bugs. None of the bugs were serious, though. You might
have been unable to compile, but if you were, everything should have
worked fine.
Jörn
--
``Plan to throw one away; you will, anyhow.''
(Fred Brooks, ``The Mythical Man-Month'', Chapter 11)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Bug in mtdblock_ro
2001-11-06 12:39 ` Jörn Engel
@ 2001-11-06 13:11 ` Simon Barber
2001-11-13 11:52 ` Jörn Engel
0 siblings, 1 reply; 6+ messages in thread
From: Simon Barber @ 2001-11-06 13:11 UTC (permalink / raw)
To: linux-mtd
the call in mtdblock_request to MTD_READ/WRITE passes nr_sectors, it should
pass current_nr_sectors.
Simon
----- Original Message -----
From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: <linux-mtd@lists.infradead.org>
Sent: Tuesday, November 06, 2001 4:39 AM
Subject: Re: MTD partitioning rewrite finished
> Hi!
>
> Kernel 2.4.14 is out, I adjusted my patches a bit and I found and
> corrected some bugs. None of the bugs were serious, though. You might
> have been unable to compile, but if you were, everything should have
> worked fine.
>
> Jörn
>
> --
> ``Plan to throw one away; you will, anyhow.''
> (Fred Brooks, ``The Mythical Man-Month'', Chapter 11)
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in mtdblock_ro
2001-11-06 13:11 ` Bug in mtdblock_ro Simon Barber
@ 2001-11-13 11:52 ` Jörn Engel
2001-11-13 15:32 ` Simon Barber
0 siblings, 1 reply; 6+ messages in thread
From: Jörn Engel @ 2001-11-13 11:52 UTC (permalink / raw)
To: Simon Barber; +Cc: linux-mtd
Moin!
> the call in mtdblock_request to MTD_READ/WRITE passes nr_sectors, it should
> pass current_nr_sectors.
Could you quickly add, what version has this problem? The filename
should be enough. When I get back from vacation (Thursday), I will
have a look at it.
Jörn
--
If you treat your beta-testers as if they're your most valuable resource,
they will respond by becoming your most valuable resource.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in mtdblock_ro
2001-11-13 11:52 ` Jörn Engel
@ 2001-11-13 15:32 ` Simon Barber
2001-11-15 13:51 ` Jörn Engel
0 siblings, 1 reply; 6+ messages in thread
From: Simon Barber @ 2001-11-13 15:32 UTC (permalink / raw)
To: Jörn Engel; +Cc: linux-mtd
I'm travelling right now - so I can't, sorry - but it's a version I checked
out from the anon CVS a few days (maybe 10) ago. With this bug fix it works
great for me. Without the fix I get a kernel panic on trying to mount a
mtd_ro partition as rootfs.
Simon
----- Original Message -----
From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: "Simon Barber" <simon@barber.net>
Cc: <linux-mtd@lists.infradead.org>
Sent: Tuesday, November 13, 2001 3:52 AM
Subject: Re: Bug in mtdblock_ro
> Moin!
>
> > the call in mtdblock_request to MTD_READ/WRITE passes nr_sectors, it
should
> > pass current_nr_sectors.
>
> Could you quickly add, what version has this problem? The filename
> should be enough. When I get back from vacation (Thursday), I will
> have a look at it.
>
> Jörn
>
> --
> If you treat your beta-testers as if they're your most valuable resource,
> they will respond by becoming your most valuable resource.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug in mtdblock_ro
2001-11-13 15:32 ` Simon Barber
@ 2001-11-15 13:51 ` Jörn Engel
0 siblings, 0 replies; 6+ messages in thread
From: Jörn Engel @ 2001-11-15 13:51 UTC (permalink / raw)
To: Erwin Authried; +Cc: David Woodhouse, Simon Barber, linux-mtd
Hi!
>>> the call in mtdblock_request to MTD_READ/WRITE passes nr_sectors, it
>>> should pass current_nr_sectors.
>>
>> Could you quickly add, what version has this problem? The filename
>> should be enough. When I get back from vacation (Thursday), I will
>> have a look at it.
>
> I'm travelling right now - so I can't, sorry - but it's a version I checked
> out from the anon CVS a few days (maybe 10) ago. With this bug fix it works
> great for me. Without the fix I get a kernel panic on trying to mount a
> mtd_ro partition as rootfs.
Erwin, this appears to be your code, if MODULE_AUTHOR is correct. Can
you have a look at it?
And David, Erwin, do you mind if I indent the request function to
Linus' beloved style? Makes reading so much easier.
Jörn
--
Every good work of software starts by
scratching a developer's personal itch.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2001-11-15 13:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-11-05 16:22 MTD partitioning rewrite finished Jörn Engel
2001-11-06 12:39 ` Jörn Engel
2001-11-06 13:11 ` Bug in mtdblock_ro Simon Barber
2001-11-13 11:52 ` Jörn Engel
2001-11-13 15:32 ` Simon Barber
2001-11-15 13:51 ` Jörn Engel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox