Re: [PATCH -next] mtd: plat_nand: remove redundant return value check of platform_get_resource()

Jingoo Han
2014-01-08T00:03:48Z

On Tuesday, January 07, 2014 10:38 PM, Wei Yongjun wrote:
>
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource(). And move those two call together
> to make the connection between them more clear.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
> drivers/mtd/nand/plat_nand.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/plat_nand.c b/drivers/mtd/nand/plat_nand.c
> index 4ebed72..0b068a5 100644
> --- a/drivers/mtd/nand/plat_nand.c
> +++ b/drivers/mtd/nand/plat_nand.c
> @@ -48,16 +48,13 @@ static int plat_nand_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return -ENXIO;
> -
> /* Allocate memory for the device structure (and zero it) */
> data = devm_kzalloc(&pdev->dev, sizeof(struct plat_nand_data),
> GFP_KERNEL);
> if (!data)
> return -ENOMEM;
>
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> data->io_base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(data->io_base))
> return PTR_ERR(data->io_base);