From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.samsung.com ([203.254.224.25]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UZbRH-0004Cp-UF for linux-mtd@lists.infradead.org; Tue, 07 May 2013 06:31:53 +0000 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMF00JQW0RJ3BC0@mailout2.samsung.com> for linux-mtd@lists.infradead.org; Tue, 07 May 2013 15:31:29 +0900 (KST) From: Jingoo Han To: 'Artem Bityutskiy' Subject: [PATCH 08/26] mtd: maps: ixp4xx: remove unnecessary platform_set_drvdata() Date: Tue, 07 May 2013 15:31:29 +0900 Message-id: <004c01ce4aec$822652d0$8672f870$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: ko Cc: linux-mtd@lists.infradead.org, Jingoo Han , 'David Woodhouse' , 'Marc Kleine-Budde' List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/mtd/maps/ixp4xx.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c index 52b3410..09c542b 100644 --- a/drivers/mtd/maps/ixp4xx.c +++ b/drivers/mtd/maps/ixp4xx.c @@ -155,8 +155,6 @@ static int ixp4xx_flash_remove(struct platform_device *dev) struct flash_platform_data *plat = dev->dev.platform_data; struct ixp4xx_flash_info *info = platform_get_drvdata(dev); - platform_set_drvdata(dev, NULL); - if(!info) return 0; -- 1.7.2.5