* [PATCH 15/26] mtd: nand: gpmi-nand: remove unnecessary platform_set_drvdata()
@ 2013-05-07 6:37 Jingoo Han
2013-05-07 8:30 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 6:37 UTC (permalink / raw)
To: 'Artem Bityutskiy'
Cc: linux-mtd, Jingoo Han, 'David Woodhouse',
'Huang Shijie', Shawn Guo
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 25ecfa1..7869210 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -1633,7 +1633,6 @@ static int gpmi_nand_probe(struct platform_device *pdev)
exit_nfc_init:
release_resources(this);
exit_acquire_resources:
- platform_set_drvdata(pdev, NULL);
dev_err(this->dev, "driver registration failed: %d\n", ret);
kfree(this);
@@ -1646,7 +1645,6 @@ static int gpmi_nand_remove(struct platform_device *pdev)
gpmi_nfc_exit(this);
release_resources(this);
- platform_set_drvdata(pdev, NULL);
kfree(this);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 15/26] mtd: nand: gpmi-nand: remove unnecessary platform_set_drvdata()
2013-05-07 6:37 [PATCH 15/26] mtd: nand: gpmi-nand: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 8:30 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2013-05-07 8:30 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Artem Bityutskiy', 'David Woodhouse', linux-mtd,
'Huang Shijie'
On Tue, May 07, 2013 at 03:37:16PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 25ecfa1..7869210 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -1633,7 +1633,6 @@ static int gpmi_nand_probe(struct platform_device *pdev)
> exit_nfc_init:
> release_resources(this);
> exit_acquire_resources:
> - platform_set_drvdata(pdev, NULL);
> dev_err(this->dev, "driver registration failed: %d\n", ret);
> kfree(this);
>
> @@ -1646,7 +1645,6 @@ static int gpmi_nand_remove(struct platform_device *pdev)
>
> gpmi_nfc_exit(this);
> release_resources(this);
> - platform_set_drvdata(pdev, NULL);
> kfree(this);
> return 0;
> }
> --
> 1.7.2.5
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 6:37 [PATCH 15/26] mtd: nand: gpmi-nand: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 8:30 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox