public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* cfi_cmdset_0002.c: Timeout for writing
@ 2002-10-28 12:37 Holger Speck
  0 siblings, 0 replies; 2+ messages in thread
From: Holger Speck @ 2002-10-28 12:37 UTC (permalink / raw)
  To: linux-mtd

Hello,

Is this correct?

Line 511 in cfi_cmdset_0002.c, function do_write_oneword:
<  timeo = jiffies + (HZ/1000); /* setting timeout to 1ms for now */

Timeo is set to jiffies because HZ/1000 = 0. This don't work in our
integration.
We use MTD in a non-linux environment. jiffies are emulated (10 ms)
Nevertheless I think, it's not correct?

Greetings,
Holger

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: cfi_cmdset_0002.c: Timeout for writing
@ 2002-10-30 14:16 Frederic Giasson
  0 siblings, 0 replies; 2+ messages in thread
From: Frederic Giasson @ 2002-10-30 14:16 UTC (permalink / raw)
  To: 'linux-mtd@lists.infradead.org'

It is correct as long as HZ/1000 gives you a 1ms value.  Most of CFI flash
device should never take more that a couple of hundreds of microseconds to
write a word.  Nevertheless, to prevent that  jiffies + (HZ/1000) = jiffies,
meaning that HZ/1000 = 0, we could replace the line 511 by

timeo = jiffies + (HZ/1000) + 1;

Frédéric Giasson 



Hello,

Is this correct?

Line 511 in cfi_cmdset_0002.c, function do_write_oneword:
<  timeo = jiffies + (HZ/1000); /* setting timeout to 1ms for now */

Timeo is set to jiffies because HZ/1000 = 0. This don't work in our
integration.
We use MTD in a non-linux environment. jiffies are emulated (10 ms)
Nevertheless I think, it's not correct?

Greetings,
Holger












--__--__--

______________________________________________________
Linux MTD discussion mailing list digest
http://lists.infradead.org/mailman/listinfo/linux-mtd/


End of linux-mtd Digest

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-10-30 13:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-10-28 12:37 cfi_cmdset_0002.c: Timeout for writing Holger Speck
  -- strict thread matches above, loose matches on Subject: below --
2002-10-30 14:16 Frederic Giasson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox