From: Jingoo Han <jg1.han@samsung.com>
To: 'Christian Engelmayer' <cengelma@gmx.at>,
'Brian Norris' <computersforpeace@gmail.com>
Cc: 'Artem Bityutskiy' <artem.bityutskiy@linux.intel.com>,
'Jingoo Han' <jg1.han@samsung.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
'Pekon Gupta' <pekon@ti.com>,
'David Woodhouse' <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: nand: omap: fix compile warning on ‘erased_sector_bitflips’
Date: Tue, 15 Apr 2014 09:33:03 +0900 [thread overview]
Message-ID: <007d01cf5842$435dcba0$ca1962e0$%han@samsung.com> (raw)
In-Reply-To: <20140415003205.0bb2cf44@spike>
On Tuesday, April 15, 2014 7:32 AM, Christian Engelmayer wrote:
>
> Commit 2c9f2365 (mtd: nand: omap: ecc.calculate: merge omap3_calculate_ecc_bch4
> in omap_calculate_ecc_bch) introduced minor compile warning
> "‘erased_sector_bitflips’ defined but not used [-Wunused-function]" when
> compiling without CONFIG_MTD_NAND_OMAP_BCH. Move function
> erased_sector_bitflips() into the same ifdef section as the only caller.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/mtd/nand/omap2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 1ff49b8..1b800bc 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1237,6 +1237,7 @@ static int __maybe_unused omap_calculate_ecc_bch(struct mtd_info *mtd,
> return 0;
> }
>
> +#ifdef CONFIG_MTD_NAND_OMAP_BCH
> /**
> * erased_sector_bitflips - count bit flips
> * @data: data sector buffer
> @@ -1276,7 +1277,6 @@ static int erased_sector_bitflips(u_char *data, u_char *oob,
> return flip_bits;
> }
>
> -#ifdef CONFIG_MTD_NAND_OMAP_BCH
> /**
> * omap_elm_correct_data - corrects page data area in case error reported
> * @mtd: MTD device structure
> --
> 1.8.3.2
next prev parent reply other threads:[~2014-04-15 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 22:32 [PATCH] mtd: nand: omap: fix compile warning on ‘erased_sector_bitflips’ Christian Engelmayer
2014-04-15 0:33 ` Jingoo Han [this message]
2014-04-15 3:58 ` Gupta, Pekon
2014-04-16 6:21 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007d01cf5842$435dcba0$ca1962e0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=cengelma@gmx.at \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox