From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.transmode.se ([83.241.175.147] helo=tmnt04.transmode.se) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1JjjE7-0001eB-OU for linux-mtd@lists.infradead.org; Wed, 09 Apr 2008 22:57:12 +0000 From: "Joakim Tjernlund" To: "'Alexey Korolev'" , =?iso-8859-1?Q?'J=F6rn_Engel'?= References: <20080404093359.GA4338@logfs.org> In-Reply-To: Subject: RE: [PATCH] Fix of broken state in CFI driver caused by FL_SHUTDOWN Date: Thu, 10 Apr 2008 00:57:07 +0200 Message-ID: <009801c89a95$09ae4680$1d0ad380$@Tjernlund@transmode.se> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Language: sv Cc: haokexin@gmail.com, akpm@linux-foundation.org, nico@cam.org, dwmw2@infradead.org, linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > -----Original Message----- > From: linux-mtd-bounces@lists.infradead.org = [mailto:linux-mtd-bounces@lists.infradead.org] On Behalf > Of Alexey Korolev > Sent: den 4 april 2008 14:22 > To: J=F6rn Engel > Cc: nico@cam.org; haokexin@gmail.com; dwmw2@infradead.org; = akpm@linux-foundation.org; linux- > mtd@lists.infradead.org > Subject: Re: [PATCH] Fix of broken state in CFI driver caused by = FL_SHUTDOWN >=20 > Hi >=20 >=20 > CFI driver in 2.6.24 kernel is broken. Not so intensive read/write = operations cause incomplete writes > which lead to kernel panics in JFFS2. > We investigated the issue - it is caused by bug in FL_SHUTDOWN = parsing code. Sometimes chip returns - > EIO as if it is in FL_SHUTDOWN state when it should wait in FL_PONT = (error in order of conditions). >=20 > The following patch fixes the bug in state parsing code of CFI. > Also I've added comments to notify developers if they want to add new = case in future. > Please include it. >=20 > Signed-off-by: Alexey Korolev > Reviewed-By: Joern Engel Acked-By: Joakim Tjernlund Guys, I think you should sent this directly to Linus as David seems unavailable ATM. It should really go into 2.6.25 Jocke