From: Jingoo Han <jg1.han@samsung.com>
To: 'Brian Norris' <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org,
'Linus Walleij' <linus.walleij@linaro.org>,
'Jingoo Han' <jg1.han@samsung.com>,
'David Woodhouse' <dwmw2@infradead.org>
Subject: [PATCH V2 2/4] mtd: fsmc_nand: use dev_warn() instead of printk()
Date: Thu, 26 Dec 2013 12:31:25 +0900 [thread overview]
Message-ID: <009d01cf01ea$f4ef4410$decdcc30$%han@samsung.com> (raw)
In-Reply-To: <009b01cf01ea$bac213d0$30463b70$%han@samsung.com>
Use dev_warn() instead of printk() to provide a better message
to userspace.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
No changes since v1.
drivers/mtd/nand/fsmc_nand.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c
index a5915f1..1550692 100644
--- a/drivers/mtd/nand/fsmc_nand.c
+++ b/drivers/mtd/nand/fsmc_nand.c
@@ -1104,8 +1104,8 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
host->ecc_place = &fsmc_ecc4_lp_place;
break;
default:
- printk(KERN_WARNING "No oob scheme defined for "
- "oobsize %d\n", mtd->oobsize);
+ dev_warn(&pdev->dev, "No oob scheme defined for oobsize %d\n",
+ mtd->oobsize);
BUG();
}
} else {
@@ -1120,8 +1120,8 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
nand->ecc.layout = &fsmc_ecc1_128_layout;
break;
default:
- printk(KERN_WARNING "No oob scheme defined for "
- "oobsize %d\n", mtd->oobsize);
+ dev_warn(&pdev->dev, "No oob scheme defined for oobsize %d\n",
+ mtd->oobsize);
BUG();
}
}
--
1.7.10.4
next prev parent reply other threads:[~2013-12-26 3:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 3:29 [PATCH 0/4] mtd: nan: use dev_err() instead of printk() Jingoo Han
2013-12-26 3:30 ` [PATCH V2 1/4] mtd: atmel_nand: " Jingoo Han
2013-12-27 6:56 ` Josh Wu
2013-12-26 3:31 ` Jingoo Han [this message]
2014-01-07 17:56 ` [PATCH V2 2/4] mtd: fsmc_nand: use dev_warn() " Linus Walleij
2013-12-26 3:31 ` [PATCH V2 3/4] mtd: orion_nand: use dev_err() " Jingoo Han
2013-12-26 3:32 ` [PATCH V2 4/4] mtd: sharpsl: " Jingoo Han
2014-01-03 18:26 ` [PATCH 0/4] mtd: nan: " Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009d01cf01ea$f4ef4410$decdcc30$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).