public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: "Joakim Tjernlund" <joakim.tjernlund@transmode.se>
To: "'Josh Boyer'" <jwboyer@gmail.com>,
	"'giulio fedel'" <giulio.fedel@andorsystems.com>,
	"'David Woodhouse'" <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: RE: jffs2 kernel dump with 2.6.22-rc7
Date: Sun, 19 Aug 2007 02:59:19 +0200	[thread overview]
Message-ID: <00bb01c7e1fc$2c810690$5267a8c0@Jocke> (raw)
In-Reply-To: <625fc13d0708181442k5efc6eb3g783ad32b2efdcadc@mail.gmail.com>

> -----Original Message-----
> From: Josh Boyer [mailto:jwboyer@gmail.com] 
> Sent: den 18 augusti 2007 23:43
> To: giulio fedel; David Woodhouse; Joakim.Tjernlund@transmode.se
> Cc: linux-mtd@lists.infradead.org
> Subject: Re: jffs2 kernel dump with 2.6.22-rc7
> 
> On 8/17/07, giulio fedel <giulio.fedel@andorsystems.com> wrote:
> > In jffs2_do_unlink() in fs/jffs2/write.c
> > the jffs2_complete_reservation(c) is called even if
> > jffs2_reserve_space() is not called. This cause an unmatched
> > up(&c->alloc_sem) so the locking mechanism does not work.
> > People using MTD_CAP_NORFLASH flash _and_ 
> CONFIG_JFFS2_SUMMARY do not
> > see the problem (see  os-linux.h for the definition of
> > jffs2_can_mark_obsolete(c)).
> >
> > I think this is your problem (it was the mine).
> 
> Hm.  That would be a regression introduced by commit
> a491486a2087ac3dfc00efb4f838c8d684afaf54 I think.

Looks like it.

> 
> Your patch seems like the correct fix.  Could you make it a strip
> level of 1 and add the appropriate Signed-off-by line?  If so, we
> should probably push this to -stable for 2.6.22 and be sure to get it
> into 2.6.23.

Yes, can't be long until .23 gets released now, hopefully this 
correction will make it in time.

> 
> josh
> 
> 

  reply	other threads:[~2007-08-19  0:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8c7950360707091227v14daf14cs48fb1377e903be6c@mail.gmail.com>
2007-08-01 18:41 ` jffs2 kernel dump with 2.6.22-rc7 shanevolpe
2007-08-17 17:14   ` giulio fedel
2007-08-18 21:08     ` Zac Medico
2007-08-18 21:42     ` Josh Boyer
2007-08-19  0:59       ` Joakim Tjernlund [this message]
2007-08-19  8:56       ` David Woodhouse
2007-08-20  3:33         ` Zac Medico
2007-08-20  9:08         ` giulio fedel
2007-07-10 11:09 shanevolpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00bb01c7e1fc$2c810690$5267a8c0@Jocke' \
    --to=joakim.tjernlund@transmode.se \
    --cc=dwmw2@infradead.org \
    --cc=giulio.fedel@andorsystems.com \
    --cc=jwboyer@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox