Re: [PATCH] mtd: spi-nor: winbond: add support for W25Q512NW-IQ/IN

From: Michael Walle <michael@walle.cc>
To: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
Cc: clg@kaod.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, p.yadav@ti.com,
	quic_ggregory@quicinc.com, quic_jiles@quicinc.com,
	tudor.ambarus@microchip.com
Subject: Re: [PATCH] mtd: spi-nor: winbond: add support for W25Q512NW-IQ/IN
Date: Sat, 16 Jul 2022 01:20:51 +0200	[thread overview]
Message-ID: <00bdb7304cf479d21b87d4a35e908fb4@walle.cc> (raw)
In-Reply-To: <2e0f02f3-0e0e-8690-a58e-bb74a21ab63e@quicinc.com>

Hi,

>> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
>> index ce5d69317d46..a2c8de250e01 100644
>> --- a/drivers/mtd/spi-nor/core.c
>> +++ b/drivers/mtd/spi-nor/core.c
>> @@ -2113,6 +2113,10 @@ spi_nor_select_uniform_erase(struct 
>> spi_nor_erase_map *map,
>> 
>>                  tested_erase = &map->erase_type[i];
>> 
>> +               /* Skip masked erase types. */
>> +               if (!tested_erase->size)
>> +                       continue;
> 
> Yes, it also works. Do you want me to update this patch with adding 
> this
> fix? Or is it good to go as is so that the INFO table can be replaced
> with SNOR_ID3 later after the fix is merged?

Please add this as a separate preceding patch to your original one
where you add the flash. Keep the INFO(0xef6020, 0, 0, 0). Then we
will replace it later with the SNOR_ID3().

Thanks for debugging!
-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/