Re: [PATCH] - NAND - Samsung LP nand feature support - nand_base.c upated

David Woodhouse
2008-04-22T15:09:32Z

On Fri, 2008-01-04 at 20:53 +0530, Sameer wrote:
> Hi,
> This patch add the Large page NAND feature support for Samsung nand flash.
>
> Regards,
> -Sameer
>
>
> Signed-off-by: Sameer U <sameersu@ti.com>
> ---
> drivers/mtd/nand/nand_base.c | 4 ++++
> 1 files changed, 4 insertions(+)
>
> Index: linux-omap-git/drivers/mtd/nand/nand_base.c
> ===================================================================
> --- linux-omap-git.orig/drivers/mtd/nand/nand_base.c
> +++ linux-omap-git/drivers/mtd/nand/nand_base.c
> @@ -2322,6 +2322,10 @@ static struct nand_flash_dev *nand_get_f
> chip->options &= ~NAND_CHIPOPTIONS_MSK;
> chip->options |= type->options & NAND_CHIPOPTIONS_MSK;
>
> + /* adding feature support for large page samsung nand */
> + if ((*maf_id == NAND_MFR_SAMSUNG) && (mtd->writesize > 512))
> + chip->options |= NAND_SAMSUNG_LP_OPTIONS;
> +

This doesn't seem to make sense. These chips have the options bit set in
the ID table by default, and we mask them _out_ for non-Samsung chips.

Which chip are you using, and why isn't it working as intended?

--
dwmw2