From: <Tudor.Ambarus@microchip.com>
To: <mail@david-bauer.net>, <linux-mtd@lists.infradead.org>,
<shuhao.mai.1990@gmail.com>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>
Subject: Re: [PATCH] mtd: spi-nor: add support for Winbond W25Q512JV
Date: Mon, 8 Mar 2021 05:50:34 +0000 [thread overview]
Message-ID: <00fdc79c-2a7f-c02f-3398-8102e5a68a53@microchip.com> (raw)
In-Reply-To: <20210213151047.11700-1-mail@david-bauer.net>
On 2/13/21 5:10 PM, David Bauer wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The Winbond W25Q512JV is a 512mb SPI-NOR chip. It supports 4K
> sectors as well as block protection and Dual-/Quad-read.
>
> Tested on: Ubiquiti UniFi 6 LR
>
> Signed-off-by: David Bauer <mail@david-bauer.net>
David, I'll take Shuhao's patch because he sent it first:
https://patchwork.ozlabs.org/project/linux-mtd/patch/20210208075303.4200-1-shuhao.mai.1990@gmail.com/
Would you make an incremental patch on top op Shuhao's, to add the
locking support?
Shuhao, can you please test the locking ops with mtd-utils?
> ---
> drivers/mtd/spi-nor/winbond.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index e5dfa786f190..49d0d7993368 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -95,6 +95,10 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> + { "w25q512jv", INFO(0xef4020, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ |
> + SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 |
> + SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP) },
Looks good. Let's put these flags in some king of order:
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 |
SPI_NOR_4BIT_BP
Cheers,
ta
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> };
> --
> 2.30.1
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-03-08 5:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 15:10 [PATCH] mtd: spi-nor: add support for Winbond W25Q512JV David Bauer
2021-03-08 5:50 ` Tudor.Ambarus [this message]
2021-03-08 18:03 ` David Bauer
2021-03-09 7:53 ` Tudor.Ambarus
2021-03-10 7:41 ` Shuhao Mai
2021-04-16 19:24 ` David Bauer
2021-05-05 2:25 ` Shuhao Mai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00fdc79c-2a7f-c02f-3398-8102e5a68a53@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mail@david-bauer.net \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=shuhao.mai.1990@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox