* Bug in rpxlite.c ?
@ 2001-03-05 21:21 Robert Kaiser
2001-03-05 21:39 ` David Woodhouse
0 siblings, 1 reply; 2+ messages in thread
From: Robert Kaiser @ 2001-03-05 21:21 UTC (permalink / raw)
To: David Woodhouse; +Cc: mtd
Hi,
I just stumbled over this line in rpxlite.c and I'm wondering if the "* ofs"
should really be a "+ ofs":
__u8 rpxlite_read8(struct map_info *map, unsigned long ofs)
{
return readb(map->map_priv_1 * ofs);
}
----------------------------------------------------------------
Robert Kaiser email: rkaiser@sysgo.de
SYSGO RTS GmbH
Am Pfaffenstein 14 phone: (49) 6136 9948-762
D-55270 Klein-Winternheim / Germany fax: (49) 6136 9948-10
To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug in rpxlite.c ?
2001-03-05 21:21 Bug in rpxlite.c ? Robert Kaiser
@ 2001-03-05 21:39 ` David Woodhouse
0 siblings, 0 replies; 2+ messages in thread
From: David Woodhouse @ 2001-03-05 21:39 UTC (permalink / raw)
To: Robert Kaiser; +Cc: mtd
On Mon, 5 Mar 2001, Robert Kaiser wrote:
> I just stumbled over this line in rpxlite.c and I'm wondering if the "* ofs"
> should really be a "+ ofs":
>
> __u8 rpxlite_read8(struct map_info *map, unsigned long ofs)
> {
> return readb(map->map_priv_1 * ofs);
> }
Heh, yeah - I suppose nobody's tried to use 8-bit chips in an rpxlite
board yet :) Please commit the change.
--
dwmw2
To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-03-05 21:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-03-05 21:21 Bug in rpxlite.c ? Robert Kaiser
2001-03-05 21:39 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox