Swich statement in cfi_probe.c

Swich statement in cfi_probe.c

[Robert Kaiser]

Hi,

I noticed that in cfi_probe.c, routine cfi_probe_new_chip(), the cases following
the switch(map->buswidth) are not terminated by a break. Thus if the probe
fails for the given buswidth, the code will try all remaining buswidths too.

Is that a bug or does it serve a purpose (if so, which ?)

Rob

----------------------------------------------------------------
Robert Kaiser                         email: rkaiser@sysgo.de
SYSGO RTS GmbH
Am Pfaffenstein 14                    phone: (49) 6136 9948-762
D-55270 Klein-Winternheim / Germany   fax:   (49) 6136 9948-10


To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

Re: Swich statement in cfi_probe.c

[David Woodhouse]

rob@sysgo.de said:
>  I noticed that in cfi_probe.c, routine cfi_probe_new_chip(), the
> cases following the switch(map->buswidth) are not terminated by a
> break. Thus if the probe fails for the given buswidth, the code will
> try all remaining buswidths too.

> Is that a bug or does it serve a purpose (if so, which ?)

Not sure. If it has a purpose, the only possibility I can think of off the 
top of my head is to work around people giving the wrong buswidth. And I 
think the code would probably break then anyway.

So it's probably a bug. If nobody shouts I'll add in the missing breaks.

--
dwmw2




To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org