From: <markus.stockhausen@gmx.de>
To: "'Miquel Raynal'" <miquel.raynal@bootlin.com>
Cc: <richard@nod.at>, <vigneshr@ti.com>, <linux-mtd@lists.infradead.org>
Subject: AW: [PATCH v2 2/2] mtd: nand: realtek-ecc: Add Realtek external ECC engine support
Date: Wed, 10 Sep 2025 17:48:20 +0200 [thread overview]
Message-ID: <017601dc226a$55da4d40$018ee7c0$@gmx.de> (raw)
In-Reply-To: <87ms72elzw.fsf@bootlin.com>
> Von: Miquel Raynal <miquel.raynal@bootlin.com>
> Gesendet: Mittwoch, 10. September 2025 10:43
>
> > + ret = FIELD_GET(RTL_ECC_RESULT, status);
> > + all_one = FIELD_GET(RTL_ECC_ALL_ONE, status);
>
> Maybe you should check whether all_one remains true if there are
> correctable bitflips in your buffer (you may use nandflipbits for that
> purpose). If not, you shall probably spend extra time when checking for
> ret checking if there are less bitflips than the ECC controller can
> correct compared to ones in the *entire* buffer, which would indicate
> that you are really in the presence of an erased page, see:
> https://elixir.bootlin.com/linux/v6.16.5/source/drivers/mtd/nand/raw/nand_base.c#L2841
>
> This helper may be moved if you need it.
ECC engine cannot handle bitflips in erased blocks.
Seems as this helper really can increase robustness
in this case. I will make use of it in the next version.
What do you mean by "can be moved"?
Markus
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-09-10 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 14:34 [PATCH v2 0/2] Realtek ECC engine Markus Stockhausen
2025-08-28 14:34 ` [PATCH v2 1/2] dt-bindings: mtd: Add realtek,rtl9301-ecc Markus Stockhausen
2025-09-01 5:14 ` Krzysztof Kozlowski
2025-09-10 8:45 ` Miquel Raynal
2025-08-28 14:34 ` [PATCH v2 2/2] mtd: nand: realtek-ecc: Add Realtek external ECC engine support Markus Stockhausen
2025-09-10 8:43 ` Miquel Raynal
2025-09-10 15:48 ` markus.stockhausen [this message]
2025-09-10 16:00 ` AW: " Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='017601dc226a$55da4d40$018ee7c0$@gmx.de' \
--to=markus.stockhausen@gmx.de \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox