From: "Joakim Tjernlund" <Joakim.Tjernlund@transmode.se>
To: "'Anders Grafström'" <grfstrm@users.sourceforge.net>,
linux-mtd@lists.infradead.org
Subject: RE: JFFS2: Return values of jffs2_block_check_erase error paths
Date: Thu, 10 Apr 2008 23:03:12 +0200 [thread overview]
Message-ID: <019d01c89b4e$4a24f6f0$de6ee4d0$@Tjernlund@transmode.se> (raw)
In-Reply-To: <47FE7392.2060900@users.sourceforge.net>
> -----Original Message-----
> From: linux-mtd-bounces@lists.infradead.org [mailto:linux-mtd-bounces@lists.infradead.org] On Behalf
> Of Anders Grafström
> Sent: den 10 april 2008 22:08
> To: linux-mtd@lists.infradead.org
> Subject: Re: JFFS2: Return values of jffs2_block_check_erase error paths
>
> Anders Grafström wrote:
> > It looks like the error paths in jffs2_block_check_erase() have wrong return values.
> > A block that failed to be erased never gets marked as bad.
> >
> > Any comments on this patch?
> >
> > Anders
> >
> >
> > diff --git a/fs/jffs2/erase.c b/fs/jffs2/erase.c
> > index a1db918..23e9dd6 100644
> > --- a/fs/jffs2/erase.c
[SNIP]
>
>
> Nobody looked at this?
> This issue caused a corrupt file system.
>
> /Anders
Looks good to me, but I think you should add your own signoff, write a
proper commit message and send it to Linus/Andrew as David appears busy.
Signed-off-by: Joakim Tjernlund <Joakim.Tjenrlund@transmode.se>
prev parent reply other threads:[~2008-04-10 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 19:29 JFFS2: Return values of jffs2_block_check_erase error paths Anders Grafström
2008-04-10 20:07 ` Anders Grafström
2008-04-10 21:03 ` Joakim Tjernlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='019d01c89b4e$4a24f6f0$de6ee4d0$@Tjernlund@transmode.se' \
--to=joakim.tjernlund@transmode.se \
--cc=grfstrm@users.sourceforge.net \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox