Re: 2.4 stuff.

[Erwin Authried <eauth@softsys.co.at>]

David Woodhouse[SMTP:dwmw2@infradead.org] wrote:
> eauth@softsys.co.at said:
> > * compatmac.h: For 2.0, the inter_module_* functions are defined as
> > empty macros if CONFIG_MODULES is not defined. If CONFIG_MODULES is
> > defined (for 2.0), compilation is stopped with #error saying that it's
> > not possible to use MTD in 2.0 kernels with module support enabled.
> 
> Careful not to make the #error break stuff that does actually work. 
> If you're compiling in all the stuff that you're actually going to need, 
> but also have CONFIG_MODULES, it should all work, shouldn't it?
> 
Yes, you are right, that's really too restrictive. You can use modules in 
general, but MTD must be linked statically. 

> It might be better to define the inter_module_get() functions to return 
> NULL but printk a warning that they've been used - which should explain to 
> the user why it's not actually working for them.
> 
Nevertheless, I think that configuration of non-working stuff should be
disallowed by the configuration script, or by aborting the compilation. 
Why should we guide the user into a trap if we know it doesn't work?

-Erwin



To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org