Re: Intel 28F128 - Linux-2.4.24 broke jffs2 v2.2?

["Brian T" <btuch@usa.net>]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]


>
> I found the problem, and the attached patch fixed it for me.  Not sure if

Sorry, forgot the diff attachment.

> this is the correct way to fix this though.  I took a line from
> jedec_probe.c and added it to cfi_util.c to get the Micron chip into the
> right mode. Micron requires the 0xFF (according to the specs) as do some
> Intel chips.
>
> Comments? If this is valid can it be added to CVS? If not, does someone
know
> the proper way of doing it?
>
> Thanks,
>
> -Brian

[-- Attachment #2: cfi_util.c.diff --]
[-- Type: application/octet-stream, Size: 756 bytes --]

nux-2.4.x/drivers/mtd/chips/cfi_util.c.orig       Tue Feb 17 15:32:24 2004
+++ linux-2.4.x/drivers/mtd/chips/cfi_util.c    Tue Feb 17 16:33:03 2004
@@ -68,6 +68,14 @@
        /* Make sure it's in read mode */
        cfi_send_gen_cmd(0xf0, 0, base, map, cfi, cfi->device_type, NULL);
 
+        /* Some misdesigned intel chips do not respond for 0xF0 for a reset,
+         * so ensure we're in read mode.  Send both the Intel and the AMD command
+         * for this.  Intel uses 0xff for this, AMD uses 0xff for NOP, so
+         * this should be safe. ALSO Some Intel's Specify 0xFF, and Micron
+        * REQUIRES it.
+         */
+        cfi_send_gen_cmd(0xFF, 0, base, map, cfi, cfi->device_type, NULL);
+
        return extp;
 }